search

JuliaCollections / LeftChildRightSiblingTrees.jl

Memory-efficient representation of a tree with arbitrary number of children/node
MIT License
16 stars 5 forks source link

OK to register? #1

Closed timholy closed 4 years ago

timholy commented 4 years ago

Do the other JuliaCollections folks think this is ready to register as a package?

oxinabox commented 4 years ago

I will review within the hour.

oxinabox commented 4 years ago

Looks good to me.

I think readme needs an example, but that can be after registration is submitted. See #2

I note that you did not preserve the git history, but I don't think thats really a problem. If you did want to change that though, this is the last chance since doing it after registration is frustrating since it chances all the commit SHAs.

I recall seeing this in one of your packages (now the read me tells me which) and thinking "that really should be in a JuliaCollectionsPackage.

I guess also it is worth thinking about if this should be called Trees.jl so to take on extras later. I am figuring you have considered that and decided not to. Which is reasonable.

timholy commented 4 years ago

Yes, there are so many potential different implementations of trees, we almost might want a sub-organization called JuliaTrees. Though not many well-maintained implementations are out there (somewhat surprisingly).

I'm not really that worried about the git history, it would be complex to get it right. (This portion of ProfileView hasn't changed in ages, so very few commits would have been relevant.)

timholy commented 4 years ago

Closed by https://github.com/JuliaRegistries/General/pull/7815