ExpandingMan commented 2 years ago

This PR contains updates for the upcoming AbstractTrees v0.4 (which, as of writing, is yet to be tagged).

I took the liberty of changing isroot to be a method of AbstractTrees.isroot. I suppose technically this is breaking, but I think it's very unlikely to break any dependencies. There's nothing preventing us from reverting this change, but it seemed silly to have two separate functions, so I changed it.

I've also removed compatibility with and CI for julia before 1.6. Since 1.6 has been LTS for a while now, I assume this will be uncontroversial.

I will update here when AbstractTrees v0.4 is tagged.

oscardssmith commented 2 years ago

This is ready to merge. the AbstractTrees release got tagged today.

codecov-commenter commented 2 years ago

Codecov Report

Merging #15 (f2b1412) into master (2b8a995) will decrease coverage by 4.41%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   96.52%   92.10%   -4.42%     
==========================================
  Files           2        2              
  Lines         115      114       -1     
==========================================
- Hits          111      105       -6     
- Misses          4        9       +5

Impacted Files	Coverage Δ
src/LeftChildRightSiblingTrees.jl	`91.34% <100.00%> (-4.81%)`	:arrow_down:
src/abstracttrees.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b8a995...f2b1412. Read the comment docs.

oscardssmith commented 2 years ago

any objections to merging?

ExpandingMan commented 2 years ago

Ok, should be ready to merge now.

JuliaCollections / LeftChildRightSiblingTrees.jl

updates for AbstractTrees v0.4 #15

Codecov Report