search

JuliaCollections / OrderedCollections.jl

Julia implementation of associative containers that preserve insertion order
MIT License
92 stars 38 forks source link

Move OrderedSet{T} constructors back as inner constructors #102

Closed fredrikekre closed 1 year ago

fredrikekre commented 1 year ago

These were moved to outer constructors in #92 leaving only the constructor from KeySet{<:OrderedDict} as the only (internal) constructor. This change meant, however, that the standard constructors for OrderedSet had to first create an empty OrderedDict to be copied and then thrown away.

fredrikekre commented 1 year ago

cc @April-Hannah-Lena who authored it and @oxinabox who reviewed it.

oxinabox commented 1 year ago

Ah we still can't optimize out obviously unused vector allocations