remove deprecations incl `sort!` piracy, bump version to 2.0

JuliaCollections / OrderedCollections.jl

Julia implementation of associative containers that preserve insertion order

MIT License

92 stars 38 forks source link

remove deprecations incl `sort!` piracy, bump version to 2.0 #109

Closed ericphanson closed 11 months ago

ericphanson commented 11 months ago

fixes https://github.com/JuliaCollections/OrderedCollections.jl/issues/25 fixes https://github.com/JuliaCollections/OrderedCollections.jl/issues/97 fixes https://github.com/JuliaCollections/OrderedCollections.jl/issues/90

Breaking changes are painful, especially with 281 dependents, but the piracy is affecting 4k indirect dependent and it seems better to remove this sooner rather than later.

Note sort! was only deprecated in v1.2, so it is indeed semver breaking to remove it.

ericphanson commented 11 months ago

If we go this route we should make a breaking release of DataStructures at the same time, as it reexports this package, as pointed out by @GunnarFarneback on slack

ericphanson commented 11 months ago

closing in favor of #110