search

JuliaComputing / AMQPClient.jl

A Julia AMQP (Advanced Message Queuing Protocol) / RabbitMQ Client.
Other
39 stars 21 forks source link

Handle empty message #54

Closed mfalt closed 2 years ago

mfalt commented 2 years ago

Fixes https://github.com/JuliaComputing/AMQPClient.jl/issues/53

The problem is that the check for putting a completed message in the recvq was only done in the function that handles BodyFrames but no body frame is sent when the message is empty. So I added a check in the processing of HeaderFrame to handle the empty case.

Edit: Sorry about the unnecessary commit, I merged thge old PR into my own fork before you pulled into master. I can recreate the PR if you want.

codecov-commenter commented 2 years ago

Codecov Report

Merging #54 (4f654c6) into master (f596fe4) will increase coverage by 0.08%. The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   82.71%   82.80%   +0.08%     
==========================================
  Files           9        9              
  Lines        1030     1035       +5     
==========================================
+ Hits          852      857       +5     
  Misses        178      178
Impacted Files Coverage Δ
src/buffered_socket.jl 0.00% <0.00%> (ø)
src/protocol.jl 87.58% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f596fe4...4f654c6. Read the comment docs.