search

JuliaComputing / AMQPClient.jl

A Julia AMQP (Advanced Message Queuing Protocol) / RabbitMQ Client.
Other
39 stars 21 forks source link

fix network byte ordering of field table #58

Closed tanmaykm closed 2 years ago

tanmaykm commented 2 years ago

Integer fields in a field table should be transmitted with network byte ordering. This fixes read and write of field tables to enforce that.

fixes #57

codecov-commenter commented 2 years ago

Codecov Report

Merging #58 (2dd6f69) into master (5f3abd5) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   83.17%   83.23%   +0.06%     
==========================================
  Files           9        9              
  Lines        1034     1038       +4     
==========================================
+ Hits          860      864       +4     
  Misses        174      174
Impacted Files Coverage Δ
src/protocol.jl 88.19% <100.00%> (+0.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nsslh commented 2 years ago

Looks good to me, thanks!

mfalt commented 2 years ago

Could we tag a release for these bugfixes?