JuliaComputing / Deprecations.jl

A database of julia deprecations and how to fix them
Other
17 stars 7 forks source link

Specify which function had positional args replaced by keyword args #65

Closed dpsanders closed 6 years ago

dpsanders commented 6 years ago
    In file /tmp/tmpH3kn24/src/intervals/functions.jl starting at line 152:
        isinteger(r) && return atomic(Interval{T}, a^round(S,r))

It would have been useful to be told that the problem was the round function, and preferably what the new syntax was.

Keno commented 6 years ago

If you hit the "Fix it" button, it'll push you a commit that introduces the changes. However, in this case the deprecation is likely wrong, since I assume S is a type. Can you show the context, so I can try and tweak the heuristics to not try to change this case?

dpsanders commented 6 years ago

The context is this after the FemtoCleaner change:

https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/7eb4ece2f0fbf3b6465f736e956b01dfe7fe6b67/src/intervals/functions.jl#L152

As you say, here S is a type, so this particular deprecation doesn't apply.

On Fri, Jun 29, 2018 at 2:28 PM, Keno Fischer notifications@github.com wrote:

If you hit the "Fix it" button, it'll push you a commit that introduces the changes. However, in this case the deprecation is likely wrong, since I assume S is a type. Can you show the context, so I can try and tweak the heuristics to not try to change this case?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaComputing/Deprecations.jl/issues/65#issuecomment-401436648, or mute the thread https://github.com/notifications/unsubscribe-auth/AALtThhSNxrGkPZO_dxZceqkfcBUMwH4ks5uBnHJgaJpZM4U9XQy .

-- Dr. David P. Sanders

Profesor Titular "B" / Associate Professor Departamento de Física, Facultad de Ciencias Universidad Nacional Autónoma de México (UNAM)

dpsanders@g dpsanders@ciencias.unam.mxmail.com / Twitter: @DavidPSanders https://twitter.com/DavidPSanders http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders https://github.com/dpsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: (+52 55) 5622 4965

dpsanders commented 6 years ago

(Actually, I think we are misusing round here anyway; it should just be a straight conversion to Int.)

On Fri, Jun 29, 2018 at 5:29 PM, David P. Sanders dpsanders@gmail.com wrote:

The context is this after the FemtoCleaner change:

https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/ 7eb4ece2f0fbf3b6465f736e956b01dfe7fe6b67/src/intervals/functions.jl#L152

As you say, here S is a type, so this particular deprecation doesn't apply.

On Fri, Jun 29, 2018 at 2:28 PM, Keno Fischer notifications@github.com wrote:

If you hit the "Fix it" button, it'll push you a commit that introduces the changes. However, in this case the deprecation is likely wrong, since I assume S is a type. Can you show the context, so I can try and tweak the heuristics to not try to change this case?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaComputing/Deprecations.jl/issues/65#issuecomment-401436648, or mute the thread https://github.com/notifications/unsubscribe-auth/AALtThhSNxrGkPZO_dxZceqkfcBUMwH4ks5uBnHJgaJpZM4U9XQy .

-- Dr. David P. Sanders

Profesor Titular "B" / Associate Professor Departamento de Física, Facultad de Ciencias Universidad Nacional Autónoma de México (UNAM)

dpsanders@g dpsanders@ciencias.unam.mxmail.com / Twitter: @DavidPSanders https://twitter.com/DavidPSanders http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders https://github.com/dpsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: (+52 55) 5622 4965

-- Dr. David P. Sanders

Profesor Titular "B" / Associate Professor Departamento de Física, Facultad de Ciencias Universidad Nacional Autónoma de México (UNAM)

dpsanders@g dpsanders@ciencias.unam.mxmail.com / Twitter: @DavidPSanders https://twitter.com/DavidPSanders http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders https://github.com/dpsanders

Cubículo / office: #414, 4o. piso del Depto. de Física

Tel.: (+52 55) 5622 4965