search

JuliaComputing / JuliaHub-Feedback

Public repo for filing JuliaHub issues
6 stars 1 forks source link

Missing direct dependencies #126

Closed SimonDanisch closed 3 years ago

SimonDanisch commented 3 years ago

Makie seems to be missing some direct dependencies, e.g. BioMakie: I'm guessing General is the source of truth here, which clearly shows BioMakie having Makie as a direct dependency: https://github.com/JuliaRegistries/General/blob/master/B/BioMakie/Deps.toml#L27 The indirect dependencies also look a bit short - I think I remember seeing a much longer list in older JuliaHub versions. Related: https://github.com/JuliaComputing/JuliaHub/issues/94

pfitzseb commented 3 years ago

That's working as intended: https://juliahub.com/ui/Packages/BioMakie/pb2pz/0.1.0?t=1 shows Makie in the list of dependencies, while https://juliahub.com/ui/Packages/BioMakie/pb2pz/0.2.0?t=1 doesn't, which is correct since Makie is only a dependency of BioMakie v0.1.x, not v0.2.x.

SimonDanisch commented 3 years ago

Hah, I guess I was parsing that TOML incorrectly, since I was convinced, that BioMakie already switched out AbstractPlotting -> Makie (but that only seems to be on master, now that I look at it more closely)... Thanks!