JuliaComputing / NgSpice.jl

This package wraps NgSpice for Julia users
MIT License
4 stars 1 forks source link

Differences between v34 and v36 ngspice_jll #33

Open sjkelly opened 2 years ago

sjkelly commented 2 years ago

On this test: https://github.com/JuliaComputing/NgSpice.jl/blob/467898a56964615fd5d54c001a497b7faf7b094f/test/wrapper_api.jl#L25-L27

(note: I added listallvecs() for debugging)

with v36:

     Testing Running tests...
Test Summary:       | Pass  Total
interface functions |    6      6
Running the simulator
listallvecs() = Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"])
getvectors: Error During Test at /home/steve/.julia/dev/NgSpice/test/wrapper_api.jl:27
  Test threw exception
  Expression: (getvec(branch))[2] == "current"
  "Vector vin#branch not found"
  Stacktrace:

with v34:

listallvecs() = Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["vin#branch", "vcc#branch", "coll", "base", "V(1)", "vcc", "emit", "time"])

I am not certain if an API has changed, but we should likely pin ngspice_jll at v34 for the time being since the tests fail.

cc @GlenHertz

sjkelly commented 2 years ago

Related? https://github.com/imr/ngspice/commit/951be0ddb03ce918e3d55d45807ffd87637be836

ven-k commented 2 years ago

With v37

@info listallvecs()
[ Info: Dict("const" => ["planck", "boltz", "echarge", "kelvin", "i", "c", "e", "pi", "FALSE", "no", "TRUE", "yes"], "tran1" => ["coll", "base", "V(1)", "vcc", "emit", "time"], "tran2" => ["coll", "base", "V(1)", "vcc", "emit", "time"])

Both vcc#branch and vin#branch are missing from all-vectors-list