search

JuliaComputing / gRPCClient.jl

A Julia gRPC Client
Other
48 stars 3 forks source link

make compatible to Julia 1.7 Downloads.jl updates #26

Closed tanmaykm closed 2 years ago

tanmaykm commented 2 years ago

Handle Downloads.jl method rename after https://github.com/JuliaLang/Downloads.jl/pull/170/commits/5bd08265f529123f2d54bc0104d6f59e86c0c1f7 Should fix #25, gRPC client hanging in Julia 1.7.3

codecov-commenter commented 2 years ago

Codecov Report

Merging #26 (ceedf76) into main (a82ef5e) will decrease coverage by 2.60%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   95.08%   92.48%   -2.61%     
==========================================
  Files           5        5              
  Lines         285      266      -19     
==========================================
- Hits          271      246      -25     
- Misses         14       20       +6
Impacted Files Coverage Δ
src/curl.jl 89.05% <66.66%> (-6.87%) :arrow_down:
src/grpc.jl 94.73% <0.00%> (-0.10%) :arrow_down:
src/gRPCClient.jl 100.00% <0.00%> (ø)
src/generate.jl 96.72% <0.00%> (+4.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a82ef5e...ceedf76. Read the comment docs.

tanmaykm commented 2 years ago

We seem to be hitting https://github.com/JuliaLang/Downloads.jl/issues/197 in the CI failures