search

JuliaComputing / gRPCClient.jl

A Julia gRPC Client
Other
48 stars 3 forks source link

tag 1.0 with ProtoBuf pinned to working version #39

Open tanmaykm opened 8 months ago

tanmaykm commented 8 months ago

gRPCClient.jl requires ProtoBuf v0.11. It is incompatible with 1.x versions of ProtoBuf as it was a significant rewrite and protobuf services are not yet supported there. This PR is to pin ProtoBuf version requirement to v0.11 and tag a new release of gRPCClient.

tanmaykm commented 8 months ago

Not sure why codegen is failing in CI. Things seem to work fine locally. Trying to dig into it

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.84%. Comparing base (f4ccd52) to head (79c747b).

Files Patch % Lines
src/grpc.jl 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== - Coverage 91.90% 91.84% -0.06% ========================================== Files 5 5 Lines 321 331 +10 ========================================== + Hits 295 304 +9 - Misses 26 27 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.