Closed roflmaostc closed 1 year ago
Unfortunately, the pretty printing seems to be hard coded into
today
which makes it hard to easily add the functionality.
Can't you just centralize it into a function, say, _print_today_tables(....; output)
and use it in both today
and talks_by
?
The issue with today
is that it only prints one day, right?
So currently to filter the full schedule and printing it in a nice way would require to call today
from the first day until the last day, wouldn't it?
Short summary:
speaker
keywords in today
are still theretalks_by
:
julia> JuliaCon.talks_by("Carsten")
Thursday 29 July 2021
BoF/Mini Track ╭───────┬─────────────────────────────────────┬──────┬──────────────────────────────────────────────────────────────────╮ │ Time │ Title │ Type │ Speaker │ ├───────┼─────────────────────────────────────┼──────┼──────────────────────────────────────────────────────────────────┤ │ 18:30 │ Julia in High-Performance Computing │ BoF │ Valentin Churavy, Michael Schlottke-Lakemper, Simon Byrne et al. │ ╰───────┴─────────────────────────────────────┴──────┴──────────────────────────────────────────────────────────────────╯
* refactored some parts like `legend` to external methods
* added `get_tracks` method to get a list of all possible tracks which can be passed to `today(track="Green")`.
Personally, I wouldn't call / link this to today
at all. This seems to just complicate things. In my eye, talks_by
and today
are orthogonal functions. One filters by time, the other by speaker. If they have common printing, put it in a separate function. If not, then not. Essentially, just put what you wrote in the issue into a talks_by
function and print it more nicely than just returning the DataFrame. You don't have to use any fancy PrettyTables.jl for the printing (like today
). You could do what now
does just with a for loop that prints the filtered talks for example.
But if you think your current approach is better for some reason, I can also take a look at it later (will head for a lunch break now 😄).
I'll try to come up with something (again) :smiley:
Hm, changes quite a bit now.
Maybe we postpone that to after JuliaCon to prevent crashing anything? At least I'm doing fine with my local version :laughing:
Hey,
as discussed in #25 here a proposal to include a filter for
speaker
.Unfortunately, the pretty printing seems to be hard coded into
today
which makes it hard to easily add the functionality.Therefore, I thought it would be OK to include that into the raw
get_conference_schedule
:Is that something you like?
Cheers,
Felix