JuliaCon / JuliaCon.jl

JuliaCon. Everywhere.
MIT License
75 stars 9 forks source link

Distributed #4

Closed carstenbauer closed 3 years ago

carstenbauer commented 3 years ago

Single worker / no distribution:

Screenshot 2021-05-31 at 10 59 37

Distributed:

Screenshot 2021-05-31 at 11 01 36

Closes #1 Closes #3

codecov[bot] commented 3 years ago

Codecov Report

Merging #4 (46bd4d9) into master (496bb85) will increase coverage by 16.66%. The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   75.00%   91.66%   +16.66%     
===========================================
  Files           1        1               
  Lines           4       12        +8     
===========================================
+ Hits            3       11        +8     
  Misses          1        1               
Impacted Files Coverage Δ
src/JuliaCon.jl 91.66% <90.90%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 496bb85...46bd4d9. Read the comment docs.

carstenbauer commented 3 years ago

@IanButterworth would be great if you could take a look!

IanButterworth commented 3 years ago

I noticed on the t-shirt that Distributed is loaded after JuliaCon, so my original fix isn't actually valid.

This can probably simply be fixed without using Requires and just using Distributed internally, and exporting @everywhere.

carstenbauer commented 3 years ago

Yes, makes sense. I dropped Requires in the latest commit.