Closed roflmaostc closed 3 months ago
The dataframe is certinaly internal. But, yeah, we should really mark the public API (the functions explicitly mentioned in README.md
) by public
, maybe even export
some of them.
(With https://github.com/carstenbauer/SysInfo.jl/blob/main/src/utils.jl this can be done in a backwards compatible way.)
Can you add a test (even if it just tests that the function exists and takes in a string)?
Should I copy paste this into JuliaCon?
Should I copy paste this into JuliaCon?
Sure, but I think this should be separate PR (after this one).
Minor thing: search_abstract
should probably better be a keyword argument. Otherwise, this looks good to me!
Isn't it one?
I guess non-breaking if we assume the dataframe was internal.