[PRE REVIEW]: AstroImages.jl

[whedon]

Submitting author: @sefffal (William R. Thompson) Repository: https://github.com/JuliaAstro/AstroImages.jl.git Version: Editor: @carstenbauer Reviewers: @oschulz, @lucaferranti Managing EiC: Valentin Churavy

Author instructions

Thanks for submitting your paper to JCON @sefffal. Currently, there isn't an JCON editor assigned to your paper.

The author's suggestion for the handling editor is @carstenbauer.

@sefffal if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JCON and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JCON submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (727.2 files/s, 92465.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           19            630            527           3465
Markdown                        20            327              0           1117
YAML                             7             14             25            169
TOML                             2              5              0             65
CSS                              1              4              0              6
JSON                             1              0              0              4
-------------------------------------------------------------------------------
SUM:                            50            980            552           4826
-------------------------------------------------------------------------------

Statistical information for the repository 'cbbd3d91e52eba14a8876b20' was
gathered on 2022/10/27.
No commited files with the specified extensions were found.

[whedon]

PDF failed to compile for issue #104 with the following error:

 Can't find any papers to compile :-(

[sefffal]

Not sure what the issue is. The paper is in the expected location paper.tex in the paper folder on the paper branch of the repo.

[vchuravy]

:warning: An error happened when generating the pdf.

[vchuravy]

:warning: An error happened when generating the pdf.

[sefffal]

The issue seems to be that the paper directory is not merged on the main branch. From the submission instructions, it seemed it possible to keep it on a separate paper branch. Is that still ok, or would I have to merge it?

[vchuravy]

:warning: An error happened when generating the pdf.

[carstenbauer]

@whedon assign @carstenbauer as editor

[whedon]

OK, the editor is @carstenbauer

[carstenbauer]

@whedon generate pdf

[whedon]

PDF failed to compile for issue #104 with the following error:

 Can't find any papers to compile :-(

[carstenbauer]

@whedon generate pdf from branch paper

[whedon]

Attempting PDF compilation from custom branch paper. Reticulating splines etc...

[sefffal]

I’m not sure what would cause this issue. I placed the template in the paper directory on the paper branch of the repo. Any suggestions?

[whedon]

PDF failed to compile for issue #104 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF

[carstenbauer]

@vchuravy Any idea what's going on here? Seems to be set up correctly (in subfolder paper in the branch paper).

[carstenbauer]

@sefffal While we resolve the technical issues, can you please recommend a few potential reviewers?

[sefffal]

Sure, thanks. Is there a list of possible reviewers listed somewhere?

[carstenbauer]

@whedon list reviewers

[whedon]

Here's the current list of reviewers: http://bit.ly/2V9GSFq

[carstenbauer]

There is this one ☝️ but it might not be very up to date, so feel free to suggest other people as well (can also be outside the Julia community if you think they might still be willing to review).

[carstenbauer]

@sefffal Regarding the paper compilation, it seems you're missing the .latexmkrc file from the template repository.

[carstenbauer]

@sefffal Quick reminder of the TODOs:

1) fix the .latexmkrc issue 2) suggest reviewers as soon as possible

Enjoy the rest of the holidays / the turn of the year!

[carstenbauer]

@whedon add @oschulz as reviewer

[whedon]

OK, @oschulz is now a reviewer

[sefffal]

@whedon generate pdf

[whedon]

PDF failed to compile for issue #104 with the following error:

 Can't find any papers to compile :-(

[sefffal]

Thanks for the reminder @carstenbauer . I've added the missing latexmk file (sorry about that!). Maybe there is another issue.

Here are some suggested reviewers: lucaferranti, mauro3, bidhya, hameye

[carstenbauer]

@whedon generate pdf from branch paper

[whedon]

Attempting PDF compilation from custom branch paper. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #104 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF

[carstenbauer]

@sefffal thanks for the suggestions. As for the compilation, please see above. There seems to be an issue with some references.

[carstenbauer]

@whedon add @lucaferranti as reviewer

[whedon]

OK, @lucaferranti is now a reviewer

[lucaferranti]

@whedon commands

[whedon]

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

[lucaferranti]

@whedon generate my checklist

[whedon]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

[lucaferranti]

I was trying to generate my review checklist, but only now I noticed this is prereview, apologies for the noise

[carstenbauer]

@sefffal Would be great if you could fix the paper compilation so that we can move to review stage.

[sefffal]

Thanks all, I will try to sort out the issues by the end of the week (attending a conference atm)

[sefffal]

@whedon generate pdf from branch paper

[whedon]

Attempting PDF compilation from custom branch paper. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #104 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Latexmk: List of undefined refs and citations:
  Citation `bezanson2017julia' on page 1 undefined on input line 17
  Citation `fitsstandard' on page 1 undefined on input line 25
Latexmk: Summary of warnings:
  Latex failed to resolve 2 citation(s)
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF

[sefffal]

Appologies but I might need some help debugging this. My paper compiles locally using latexmk, and I'm following the template closely. For example, the bezanson2017julia citation is taken verbatim from https://github.com/JuliaCon/JuliaConSubmission.jl/

In the meantime I committed my locally compiled PDF to show what it should look like: https://github.com/JuliaAstro/AstroImages.jl/blob/paper/paper/paper.pdf

[carstenbauer]

Hey all, unfortunately I couldn't yet resolve the paper compilation issue here. Nonetheless, since @sefffal has provided the PDF here I would like to still move this to review stage. (Hopefully, we can fix the compilation issues later.)

[carstenbauer]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/JuliaCon/proceedings-review/issues/126.