JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: RangeEnclosures.jl: A framework to bound function ranges #110

Closed whedon closed 1 year ago

whedon commented 1 year ago

Submitting author: @lucaferranti (Luca Ferranti) Repository: https://github.com/JuliaReach/RangeEnclosures.jl Version: Editor: @odow Reviewers: @dpsanders, @blegat Managing EiC: Mathieu Besançon

Author instructions

Thanks for submitting your paper to JCON @lucaferranti. Currently, there isn't an JCON editor assigned to your paper.

The author's suggestion for the handling editor is @carstenbauer.

@lucaferranti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JCON and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JCON submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 1 year ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 1 year ago

Failed to discover a Statement of need section in paper

whedon commented 1 year ago

Wordcount for paper.tex is 921

whedon commented 1 year ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.03 s (1407.4 files/s, 135405.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            267            178           2392
Julia                           19            128             69            511
Markdown                         6            119              0            323
YAML                             8             12              0            207
Lisp                             1             59              0            142
TOML                             3              5              0             50
Ruby                             1              8              4             45
CSS                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            47            598            251           3673
-------------------------------------------------------------------------------

Statistical information for the repository 'e6eec35cb5abcc17573134ab' was
gathered on 2022/10/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
lucaferranti                     1            57              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
lucaferranti                 57          100.0          0.0                7.02
whedon commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.29007/zzc7 is OK
- 10.1137/141000671 is OK
- 10.1023/A:1021368627321 is OK
- 10.1023/B:NUMA.0000049462.70970.b6 is OK
- 10.1137/1.9780898717716 is OK
- 10.21105/jcon.00097 is OK

MISSING DOIs

- 10.1146/annurev-control-071420-081941 may be a valid DOI for title: Set propagation techniques for reachability analysis

INVALID DOIs

- None
whedon commented 1 year ago

PDF failed to compile for issue #110 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
schillic commented 1 year ago

@whedon generate pdf

whedon commented 1 year ago

PDF failed to compile for issue #110 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
schillic commented 1 year ago

@whedon commands

whedon commented 1 year ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
schillic commented 1 year ago

@whedon check references

schillic commented 1 year ago

@whedon check references

whedon commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.29007/zzc7 is OK
- 10.1146/annurev-control-071420-081941 is OK
- 10.1137/141000671 is OK
- 10.1023/A:1021368627321 is OK
- 10.1023/B:NUMA.0000049462.70970.b6 is OK
- 10.1137/1.9780898717716 is OK
- 10.21105/jcon.00097 is OK

MISSING DOIs

- None

INVALID DOIs

- None
lucaferranti commented 1 year ago

@whedon generate pdf from branch master

whedon commented 1 year ago
Attempting PDF compilation from custom branch master. Reticulating splines etc...
whedon commented 1 year ago

PDF failed to compile for issue #110 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
lucaferranti commented 1 year ago

Refer to 'paper.log' for details

where can I find the log?

schillic commented 1 year ago

@whedon generate pdf

whedon commented 1 year ago

PDF failed to compile for issue #110 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
carstenbauer commented 1 year ago

@whedon assign @odow as editor

odow commented 1 year ago

@schillic try removing the xspace package. It might not be in the docker image that we use to build the LaTeX.

Do you have any suggestions for potential reviewers?

lucaferranti commented 1 year ago

e.g. @dpsanders would make a good reviewer

odow commented 1 year ago

where can I find the log?

@carstenbauer any pointers?

odow commented 1 year ago

Ah. @lucaferranti you're missing the https://github.com/JuliaCon/JuliaConSubmission.jl/blob/master/paper/.latexmkrc file from the template repository.

schillic commented 1 year ago

@whedon generate pdf from branch schillic/paper

whedon commented 1 year ago
Attempting PDF compilation from custom branch schillic/paper. Reticulating splines etc...
whedon commented 1 year ago

PDF failed to compile for issue #110 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
schillic commented 1 year ago

@odow I tried your suggestions here. Unfortunately they did not help.

EDIT: We saw that most other submissions have such an error as well. Should we upload the PDF in the repository for now (so the reviewers can access it directly)?

odow commented 1 year ago

Here's one that worked two hours ago, so it's something with this paper: https://github.com/JuliaCon/proceedings-review/issues/116#issuecomment-1346964360

odow commented 1 year ago

You've called it index.latexmkrc, not .latexmkrc:

https://github.com/JuliaReach/RangeEnclosures.jl/blob/schillic/paper/paper/index.latexmkrc

schillic commented 1 year ago

@whedon generate pdf from branch schillic/paper

whedon commented 1 year ago
Attempting PDF compilation from custom branch schillic/paper. Reticulating splines etc...
whedon commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

schillic commented 1 year ago

@odow nailed it, thanks!

odow commented 1 year ago

@blegat and @dpsanders are you interested in reviewing this paper for the JuliaCon proceedings?

Given the lead-up to Christmas, our deadline for the first round isn't until the end of January, so there's no expectation that you'll start the review now if you are busy. I just need an indication that you're willing, otherwise I will need to find other reviewers. If you're willing, I'll ping you again in early January with a reminder.

dpsanders commented 1 year ago

Hi @odow, I'm happy to review this submission.

odow commented 1 year ago

@whedon add @dpsanders as reviewer

whedon commented 1 year ago

I'm sorry @odow, I'm afraid I can't do that. That's something only editors are allowed to do.

odow commented 1 year ago

@matbesancon help! The bot won't listen to me

matbesancon commented 1 year ago

@whedon add @odow as editor

whedon commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
matbesancon commented 1 year ago

@whedon assign @odow as editor

matbesancon commented 1 year ago

insolent @whedon

odow commented 1 year ago

@whedon add @dpsanders as reviewer

whedon commented 1 year ago

I'm sorry @odow, I'm afraid I can't do that. That's something only editors are allowed to do.

matbesancon commented 1 year ago

@vchuravy do you know if we have other steps to add @odow as editor?

odow commented 1 year ago

What if you try again? It unassigned me, so perhaps this time it'll assign me.

matbesancon commented 1 year ago

@whedon assign @odow as editor

matbesancon commented 1 year ago

@whedon assign @odow as editor

lucaferranti commented 1 year ago

@whedon generate pdf