JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: GraphPPL.jl: A Julia Package for probabilistic model and inference constraints specification #112

Closed whedon closed 1 year ago

whedon commented 1 year ago

Submitting author: @bvdmitri (Dmitry Bagaev) Repository: https://github.com/biaslab/GraphPPL.jl Version: Editor: @matbesancon Reviewers: @theogf, @sethaxen Managing EiC: Valentin Churavy

Author instructions

Thanks for submitting your paper to JCON @bvdmitri. Currently, there isn't an JCON editor assigned to your paper.

The author's suggestion for the handling editor is @matbesancon.

@bvdmitri if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JCON and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JCON submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 1 year ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 1 year ago

PDF failed to compile for issue #112 with the following error:

 Can't find any papers to compile :-(
carstenbauer commented 1 year ago

@whedon assign @matbesancon as editor

whedon commented 1 year ago

OK, the editor is @matbesancon

bvdmitri commented 1 year ago

The paper is in the paper/julia_proceedings_2022 branch.

bvdmitri commented 1 year ago

@matbesancon Hey! Is there any progress on this submission?

matbesancon commented 1 year ago

Hi, thanks for pinging, we are still looking for reviewers on our side

matbesancon commented 1 year ago

@whedon add @theogf as reviewer

whedon commented 1 year ago

OK, @theogf is now a reviewer

matbesancon commented 1 year ago

@whedon add @sethaxen as reviewer

whedon commented 1 year ago

OK, @sethaxen is now a reviewer

matbesancon commented 1 year ago

@whedon generate pdf from branch julia_proceedings_2022

whedon commented 1 year ago
Attempting PDF compilation from custom branch julia_proceedings_2022. Reticulating splines etc...
whedon commented 1 year ago

PDF failed to compile for issue #112 with the following error:

 Can't find any papers to compile :-(
matbesancon commented 1 year ago

@whedon generate pdf from branch paper/julia_proceedings_2022

whedon commented 1 year ago
Attempting PDF compilation from custom branch paper/julia_proceedings_2022. Reticulating splines etc...
whedon commented 1 year ago

PDF failed to compile for issue #112 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.aux'
------------
Run number 2 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Rule 'pdflatex': File changes, etc:
   Changed files, or newly in use since previous run(s):
      'paper.out'
------------
Run number 3 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
matbesancon commented 1 year ago

@bvdmitri can you check that you didn't modify anything non-standard in the paper folder?

bvdmitri commented 1 year ago

@matbesancon No, last commit has been made more than 4 months ago. I checked it now locally using the following instructions https://juliacon.github.io/proceedings-guide/author/#local_build and it works perfectly.

bvdmitri commented 1 year ago

@matbesancon Here is the pdf document generated locally paper.pdf

bvdmitri commented 1 year ago

@matbesancon The official guideline mentions the Whedon bot, but it seems to me that it does not support paper.tex submissions, which is the only possible way for the JuliaCon Proceedings. Thus I have no possibility to make sure that the whedon works without errors. whedon docker image and GitHub Action do work with paper.md submissions, but I don't see any documentation on how to run them for paper.tex submissions.

The log posted in the previous message is uninformative and does not really help to identify the issue. Is there a way to get the full log file?

matbesancon commented 1 year ago

@bvdmitri one thing to watch out: we need the .latexrc file, check the files here: https://github.com/JuliaCon/JuliaConSubmission.jl/tree/master/paper

matbesancon commented 1 year ago

that's why the logs was breaking early

bvdmitri commented 1 year ago

@whedon generate pdf from branch paper/julia_proceedings_2022

whedon commented 1 year ago
Attempting PDF compilation from custom branch paper/julia_proceedings_2022. Reticulating splines etc...
whedon commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

bvdmitri commented 1 year ago

@matbesancon Thanks for the help, the article builds without any problem now

matbesancon commented 1 year ago

@whedon start review

whedon commented 1 year ago

OK, I've started the review over in https://github.com/JuliaCon/proceedings-review/issues/123.