JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: Recommendation.jl: A Framework for Building Recommender Systems in Julia #119

Closed whedon closed 2 months ago

whedon commented 1 year ago

Submitting author: !--author-handle-->@takuti<!--end-author-handle-- (Takuya Kitazawa) Repository: https://github.com/takuti/Recommendation.jl Branch with paper.md (empty if default branch): Version: Editor: !--editor-->@lucaferranti<!--end-editor-- Reviewers: @lucaferranti, @abhijithch, @pgimenez Managing EiC: Valentin Churavy

Author instructions

Thanks for submitting your paper to JCON @takuti. Currently, there isn't an JCON editor assigned to your paper.

The author's suggestion for the handling editor is @carstenbauer.

@takuti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JCON and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JCON submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

takuti commented 9 months ago

@whedon check references

whedon commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title:  Julia: A Fresh Approach to Numerical Computing 
- 10.1145/3340531.3412778 may be a valid DOI for title:  LensKit for Python: Next-Generation Software for Recommender Systems Experiments 
- 10.18653/v1/d19-1018 may be a valid DOI for title:  Justifying Recommendations using Distantly-Labeled Reviews and Fine-Grained Aspects 
- 10.1145/138859.138867 may be a valid DOI for title:  Using Collaborative Filtering to Weave an Information Tapestry 
- 10.1145/3130348.3130372 may be a valid DOI for title:  An Algorithmic Framework for Performing Collaborative Filtering 
- 10.1007/978-0-387-85820-3_3 may be a valid DOI for title:  Content-Based Recommender Systems: State of the Art and Trends 
- 10.1145/2792838.2796542 may be a valid DOI for title:  Factorization Machines for Hybrid Recommendation Systems Based on Behavioral, Product, and Customer Data 
- 10.1145/2168752.2168771 may be a valid DOI for title:  Factorization Machines with libFM 
- 10.1145/2124295.2124313 may be a valid DOI for title:  Learning Recommender Systems with Adaptive Regularization 
- 10.1007/978-0-387-85820-3_8 may be a valid DOI for title:  Evaluating Recommendation Systems 
- 10.1145/1060745.1060754 may be a valid DOI for title:  Improving Recommendation Lists through Topic Diversification 
- 10.2139/ssrn.3378581 may be a valid DOI for title:  Recommender Systems and Their Ethical Challenges 

INVALID DOIs

- None
takuti commented 9 months ago

Hi @lucaferranti, can you help me to know how MISSING DOIs are identified? I added doi fields to the reported citations, but it looks like the change doesn't resolve the warning.

https://github.com/takuti/Recommendation.jl/pull/66/commits/968df15cc924c80fe8353c436e596ad4b79f6657

lucaferranti commented 9 months ago

@whedon generate pdf from branch paper-fix

whedon commented 9 months ago
Attempting PDF compilation from custom branch paper-fix. Reticulating splines etc...
whedon commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lucaferranti commented 9 months ago

@whedon check references

whedon commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title:  Julia: A Fresh Approach to Numerical Computing 
- 10.1145/3340531.3412778 may be a valid DOI for title:  LensKit for Python: Next-Generation Software for Recommender Systems Experiments 
- 10.18653/v1/d19-1018 may be a valid DOI for title:  Justifying Recommendations using Distantly-Labeled Reviews and Fine-Grained Aspects 
- 10.1145/138859.138867 may be a valid DOI for title:  Using Collaborative Filtering to Weave an Information Tapestry 
- 10.1145/3130348.3130372 may be a valid DOI for title:  An Algorithmic Framework for Performing Collaborative Filtering 
- 10.1007/978-0-387-85820-3_3 may be a valid DOI for title:  Content-Based Recommender Systems: State of the Art and Trends 
- 10.1145/2792838.2796542 may be a valid DOI for title:  Factorization Machines for Hybrid Recommendation Systems Based on Behavioral, Product, and Customer Data 
- 10.1145/2168752.2168771 may be a valid DOI for title:  Factorization Machines with libFM 
- 10.1145/2124295.2124313 may be a valid DOI for title:  Learning Recommender Systems with Adaptive Regularization 
- 10.1007/978-0-387-85820-3_8 may be a valid DOI for title:  Evaluating Recommendation Systems 
- 10.1145/1060745.1060754 may be a valid DOI for title:  Improving Recommendation Lists through Topic Diversification 
- 10.2139/ssrn.3378581 may be a valid DOI for title:  Recommender Systems and Their Ethical Challenges 

INVALID DOIs

- None
lucaferranti commented 9 months ago

@takuti comparing this with other submissions where DOIs are fine, the only difference I see, is that others use curly braces instead of quotes, e.g. doi = {10.1137/141000671}, could you try that?

I have fixed the errors as shown above. Working PR is https://github.com/takuti/Recommendation.jl/pull/66 on the paper-fix branch - let me know if I should merge the branch or I can keep working on it throughout the review process.

sorry I only now saw this never got answered. This depends on where you want to keep the paper folder, there are two strategies

  1. Have the paper/ in the main branch
  2. Host the paper/ in a separete branch

If you want the paper/ to be in main, then I think you should merge the PR. If instead you dont want to incude the paer in the main branch, then you can close the PR and keep it as now. I see however you already have a paper/ folder in main, so maybe you want to go with option 1?

takuti commented 9 months ago

@whedon generate pdf from branch paper-fix

whedon commented 9 months ago
Attempting PDF compilation from custom branch paper-fix. Reticulating splines etc...
whedon commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

takuti commented 9 months ago

@whedon check references

whedon commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title:  Julia: A Fresh Approach to Numerical Computing 
- 10.1145/3340531.3412778 may be a valid DOI for title:  LensKit for Python: Next-Generation Software for Recommender Systems Experiments 
- 10.18653/v1/d19-1018 may be a valid DOI for title:  Justifying Recommendations using Distantly-Labeled Reviews and Fine-Grained Aspects 
- 10.1145/138859.138867 may be a valid DOI for title:  Using Collaborative Filtering to Weave an Information Tapestry 
- 10.1145/3130348.3130372 may be a valid DOI for title:  An Algorithmic Framework for Performing Collaborative Filtering 
- 10.1007/978-0-387-85820-3_3 may be a valid DOI for title:  Content-Based Recommender Systems: State of the Art and Trends 
- 10.1145/2792838.2796542 may be a valid DOI for title:  Factorization Machines for Hybrid Recommendation Systems Based on Behavioral, Product, and Customer Data 
- 10.1145/2168752.2168771 may be a valid DOI for title:  Factorization Machines with libFM 
- 10.1145/2124295.2124313 may be a valid DOI for title:  Learning Recommender Systems with Adaptive Regularization 
- 10.1007/978-0-387-85820-3_8 may be a valid DOI for title:  Evaluating Recommendation Systems 
- 10.1145/1060745.1060754 may be a valid DOI for title:  Improving Recommendation Lists through Topic Diversification 
- 10.2139/ssrn.3378581 may be a valid DOI for title:  Recommender Systems and Their Ethical Challenges 

INVALID DOIs

- None
takuti commented 9 months ago

@lucaferranti Thank you for the response. I replaced double-quotes with curly braces https://github.com/takuti/Recommendation.jl/pull/66/commits/082e38d3724d59fff13088123eab6d804c748252, but the warning still remains...

By the way, do we really need to "fix" the warning? It looks like the bot doesn't check the accuracy of DOIs, and JOSS documentation says these messages are just for reference.

Also thanks for commenting on the previous question about the branch. Yes, I'm taking Option 1, and I just wanted to check if I should merge the topic branch paper-fix to main NOW or AFTER peer-review is completed. It sounds like it doesn't really matter - I will merge once the DOI stuff is resolved.

lucaferranti commented 9 months ago

@takuti , the DOI issue should be fixed before final publication, but it does not of course prevent before starting the review (once I find reviewers). I will also try to take a closer look at the issue and try to help with that.

lucaferranti commented 8 months ago

@whedon assign @lucaferranti as reviewer

whedon commented 8 months ago

OK, @lucaferranti is now a reviewer

lucaferranti commented 8 months ago

@whedon remove lucaferranti as reviewer

whedon commented 8 months ago

OK, lucaferranti is no longer a reviewer

lucaferranti commented 8 months ago

@whedon assign lucaferranti as editor

whedon commented 8 months ago

OK, the editor is @lucaferranti

lucaferranti commented 8 months ago

Hi @abhijithch, :wave:

would you be willing to review this JuliaCon submission? You can read more details about JuliaCon proceedings review process here and you are of course welcome to ask me any clarifying questions you may have.

lucaferranti commented 8 months ago

Hi @essenciary :wave: ,

would you be willing to review this JuliaCon submission? You can read more details about JuliaCon proceedings review process here and you are of course welcome to ask me any clarifying questions you may have.

lucaferranti commented 7 months ago

@whedon generate pdf from branch paper-fix

whedon commented 7 months ago
Attempting PDF compilation from custom branch paper-fix. Reticulating splines etc...
whedon commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lucaferranti commented 7 months ago

@whedon add @abhijithch as reviewer

whedon commented 7 months ago

OK, @abhijithch is now a reviewer

takuti commented 3 months ago

Hello @lucaferranti - Just checking in if I can still expect any updates for publication. If not in the near future, I will post the paper to arXiv not to waste my work for the time being. Let me know what your suggestion is.

lucaferranti commented 3 months ago

Hi, @takuti apologies for the delay! I will try to get a reviewer asap and hopefully this will move forward soon.

Regarding your question, arxiv is a preprint and you can post the paper there while it is under review. Hence, feel free to so so if you like.

lucaferranti commented 3 months ago

@editorialbot generate pdf

PGimenez commented 2 months ago

@lucaferranti you can add me as a reviewer, I'm familiar with matrix completion and recommender systems

lucaferranti commented 2 months ago

Thank you!!! And perfect timing since we literally got the last infra fixeda

lucaferranti commented 2 months ago

@editorialbot add @pgimenez as reviewer

editorialbot commented 2 months ago

@pgimenez added to the reviewers list!

lucaferranti commented 2 months ago

@editorialbot start review

lucaferranti commented 2 months ago

@xuanxu it seems the review is started successfully, but tthis was not closed automatically

xuanxu commented 2 months ago

@lucaferranti looks like it failed because there was no value for version before starting the review issue (when this submission was created that was not required, now it is).

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/JuliaCon/proceedings-review/issues/147.