Closed whedon closed 1 year ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dawbarton, @Datseris it looks like you're currently assigned to review this paper :tada:.
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/JuliaCon/proceedings-review) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿
To fix this do the following two things:
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
@whedon generate pdf
Failed to discover a Statement of need
section in paper
Wordcount for paper.tex
is 858
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Software report (experimental):
github.com/AlDanial/cloc v 1.88 T=0.08 s (279.6 files/s, 139678.4 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
SVG 1 0 0 7144
TeX 8 246 188 2399
Julia 10 183 178 529
Ruby 1 8 4 45
Markdown 1 17 0 29
YAML 1 0 0 22
-------------------------------------------------------------------------------
SUM: 22 454 370 10168
-------------------------------------------------------------------------------
Statistical information for the repository '9f658cf947335d2ff50f888e' was
gathered on 2023/01/09.
The following historical commit information, by author, was found:
Author Commits Insertions Deletions % of changes
mmanzi95 1 57 0 100.00
Below are the number of rows from each author that have survived and are still
intact in the current revision:
Author Rows Stability Age % in comments
mmanzi95 57 100.0 0.0 7.02
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.2139/ssrn.4041723 is OK
- 10.1016/0370-1573(79)90023-1 is OK
- 10.1007/978-3-540-85146-2 is OK
- 10.1017/9781108768900 is OK
- 10.1142/S0218127416300366 is OK
- 10.1142/S0218127416300366 is OK
- 10.1007/978-94-009-7793-8_19 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
:wave: @Datseris, please update us on how your review is going (this is an automated reminder).
:wave: @dawbarton, please update us on how your review is going (this is an automated reminder).
Hello, I'd like to submit my review. At the moment, I think this paper needs major revisions, according to the comments:
local_growth_rates
that exists in DynamicalSystems.jl and provides finite time lyapunov exponents? If it is different, how?Just to add to Datseris' review -
src
folder appears to only contain demos. The method described just seems to be the lines
Delta = transpose(dzt_dz0)*dzt_dz0
eig_val = eigen(Delta).values
FTLE[j, i] = 1/T * log(sqrt(maximum(eig_val)))
As it stands, I'm not sure why this should be published.
Hey @matteoettam09, please take a look at the reviews by @Datseris and @dawbarton. They've both expressed that a major revision of the paper / the repository is necessary. It would be great if you could comment on the raised criticism and could decide whether you want to move forward with this.
Hello @carstenbauer, @Datseris, @dawbarton.
Sorry, for the late feedback.
In order:
We currently don't have the time resources to move forward with this, sorry, hopefully someone reading this thread read the work, its pain points and push it forward.
Alright, I'm closing for the reasons above. In any case, thanks @Datseris @dawbarton for your reviews!
@editorialbot reject
Paper rejected.
Submitting author: !--author-handle-->@matteoettam09<!--end-author-handle-- (Matteo Manzi) Repository: https://github.com/matteoettam09/FTLE.jl Branch with paper.md (empty if default branch): Version: Editor: !--editor-->@carstenbauer<!--end-editor-- Reviewers: @dawbarton, @Datseris Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dawbarton & @Datseris, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @carstenbauer know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @dawbarton
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content
[ ] Context: is the scientific context motivating the work correctly presented?
[ ] Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
[ ] Results: are the results presented and compared to approaches with similar goals?
Review checklist for @Datseris
Conflict of interest
[x] As the reviewer I confirm that I have read the JuliaCon conflict of interest policy and that there are no conflicts of interest for me to review this work.
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content