search

JuliaCon / proceedings-review

6 stars 1 forks source link

[REVIEW]: Tracking.jl: Accelerating multi-antenna GNSS receivers with CUDA #128

Closed whedon closed 7 months ago

whedon commented 1 year ago

Submitting author: !--author-handle-->@ozmaden<!--end-author-handle-- (Can Özmaden) Repository: https://github.com/ozmaden/GPUAcceleratedTracking Branch with paper.md (empty if default branch): Version: Editor: !--editor-->@fcdimitr<!--end-editor-- Reviewers: @lucaferranti, @maleadt Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/f7e56fca6680deb1dc9c3eeb513aa431"><img src="https://proceedings.juliacon.org/papers/f7e56fca6680deb1dc9c3eeb513aa431/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/f7e56fca6680deb1dc9c3eeb513aa431/status.svg)](https://proceedings.juliacon.org/papers/f7e56fca6680deb1dc9c3eeb513aa431)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@lucaferranti & @maleadt, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vchuravy know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @lucaferranti

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Paper format

Content

Code of Conduct

General checks

Functionality

Documentation

Paper format

Content

whedon commented 1 year ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @lucaferranti, @maleadt it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/JuliaCon/proceedings-review) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/JuliaCon/proceedings-review:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 1 year ago

Failed to discover a Statement of need section in paper

whedon commented 1 year ago

Wordcount for paper.tex is 5545

whedon commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 1 year ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.21 s (204.6 files/s, 295535.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              8              1              1          48211
Julia                           21            414            924           5980
TeX                              8            325            231           2734
TOML                             2            306              1           1418
Ruby                             1              8              4             45
Markdown                         1             13              0             35
YAML                             1              2              0             21
-------------------------------------------------------------------------------
SUM:                            42           1069           1161          58444
-------------------------------------------------------------------------------

Statistical information for the repository '9a72e007480fe464c68fc4a2' was
gathered on 2023/04/21.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Can Ozmaden                      1            57              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Can Ozmaden                  57          100.0          0.0                7.02
whedon commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1287/opre.38.5.911 is OK
- 10.1109/ISSSTA.1992.665623 is OK
- 10.3390/s121013417 is OK
- 10.1109/TWC.2004.833467 is OK
- 10.1109/TPDS.2018.2872064 is OK
- 10.21105/joss.02673 is OK
- 10.5281/zenodo.5870363 is OK
- 10.1109/ICINIS.2008.99 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.5933659 is OK
- 10.5281/zenodo.5933726 is OK

MISSING DOIs

- 10.1007/s10291-016-0516-2 may be a valid DOI for title: Correlation acceleration in GNSS software receivers using a CUDA-enabled GPU
- 10.1109/plans.1996.509077 may be a valid DOI for title: Adaptive antenna arrays for interference cancellation in GPS and GLONASS receivers
- 10.33012/2018.15873 may be a valid DOI for title: Estimation of antenna array manifolds based on sparse measurements
- 10.1186/s13638-018-1132-3 may be a valid DOI for title: Research on multi-constellation GNSS compatible acquisition strategy based on GPU high-performance operation
- 10.22457/jmi.v20a05192 may be a valid DOI for title: Satellite Navigation Simulation Signal Generation Method Based on GPU Acceleration
- 10.1109/globalsip.2015.7418431 may be a valid DOI for title: An accelerated signal tracking module using a heterogeneous multi-GPU platform for real-time GNSS software receiver
- 10.4018/ijghpc.2014070102 may be a valid DOI for title: Accelerating a cloud-based software GNSS receiver

INVALID DOIs

- https://doi.org/10.1002/navi.29 is INVALID because of 'https://doi.org/' prefix
whedon commented 1 year ago

:wave: @maleadt, please update us on how your review is going (this is an automated reminder).

whedon commented 1 year ago

:wave: @lucaferranti, please update us on how your review is going (this is an automated reminder).

whedon commented 1 year ago

:wave: @maleadt, please update us on how your review is going (this is an automated reminder).

whedon commented 1 year ago

:wave: @lucaferranti, please update us on how your review is going (this is an automated reminder).

lucaferranti commented 1 year ago

apologies for the radio silence, I"ll try to get the review done this week!

lucaferranti commented 1 year ago

@whedon generate pdf

whedon commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lucaferranti commented 1 year ago

@whedon check references

whedon commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1287/opre.38.5.911 is OK
- 10.1109/ISSSTA.1992.665623 is OK
- 10.3390/s121013417 is OK
- 10.1109/TWC.2004.833467 is OK
- 10.1109/TPDS.2018.2872064 is OK
- 10.21105/joss.02673 is OK
- 10.5281/zenodo.5870363 is OK
- 10.1109/ICINIS.2008.99 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.5933659 is OK
- 10.5281/zenodo.5933726 is OK

MISSING DOIs

- 10.1007/s10291-016-0516-2 may be a valid DOI for title: Correlation acceleration in GNSS software receivers using a CUDA-enabled GPU
- 10.1109/plans.1996.509077 may be a valid DOI for title: Adaptive antenna arrays for interference cancellation in GPS and GLONASS receivers
- 10.33012/2018.15873 may be a valid DOI for title: Estimation of antenna array manifolds based on sparse measurements
- 10.1186/s13638-018-1132-3 may be a valid DOI for title: Research on multi-constellation GNSS compatible acquisition strategy based on GPU high-performance operation
- 10.22457/jmi.v20a05192 may be a valid DOI for title: Satellite Navigation Simulation Signal Generation Method Based on GPU Acceleration
- 10.1109/globalsip.2015.7418431 may be a valid DOI for title: An accelerated signal tracking module using a heterogeneous multi-GPU platform for real-time GNSS software receiver
- 10.4018/ijghpc.2014070102 may be a valid DOI for title: Accelerating a cloud-based software GNSS receiver

INVALID DOIs

- https://doi.org/10.1002/navi.29 is INVALID because of 'https://doi.org/' prefix
matbesancon commented 9 months ago

@whedon assign @lucaferranti as editor

lucaferranti commented 9 months ago

@whedon show commands

whedon commented 9 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
lucaferranti commented 9 months ago

@whedon set 0.1 as version

whedon commented 9 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

matbesancon commented 9 months ago

@whedon assign @luraess as editor

matbesancon commented 9 months ago

@whedon assign @fcdimitr as editor

ranjanan commented 9 months ago

@whedon assign @lucaferranti as editor

ranjanan commented 9 months ago

@carstenbauer do you have the power to assign editors?

lucaferranti commented 9 months ago

@whedon set 0.1 as version

whedon commented 9 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 9 months ago

btw, the editor here should not be me, but @fcdimitr

lucaferranti commented 9 months ago

maybe editors need to be members of the juliacon organization?

matbesancon commented 8 months ago

@whedon set @fcdimitr as reviewer

whedon commented 8 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
matbesancon commented 8 months ago

@whedon assign @fcdimitr as editor

fcdimitr commented 7 months ago

:wave: @coezmaden: I see that @maleadt has posted his review in a separate issue (https://github.com/coezmaden/GPUAcceleratedTracking/issues/5). Could you update us on your efforts to address the comments and revise the manuscript?

:wave: @lucaferranti: Could you give us an update on how your review is going?

Thank you!

fcdimitr commented 7 months ago

👋 @coezmaden: Could you please update us on the progress of addressing the reviewer's comments? I enabled the flag author-action-required until we hear back from you. If we do not receive a response within 25 days, the issue will be closed, and you will have to start a new submission from scratch. Thank you!

coezmaden commented 7 months ago

👋 @coezmaden: Could you please update us on the progress of addressing the reviewer's comments? I enabled the flag author-action-required until we hear back from you. If we do not receive a response within 25 days, the issue will be closed, and you will have to start a new submission from scratch. Thank you!

Sorry for the late reply and inactivity. The original hardware and the funding for the project behind this submission has been finalized after the review came. I am afraid I cannot provide any viable update to the paper due to time and the lack of original hardware reasons. Apologies for the caused inconvenience, but I must retract this submission.

fcdimitr commented 7 months ago

Thank you for the update; I am closing this issue.

lucaferranti commented 2 months ago

@editorialbot reject

editorialbot commented 2 months ago

Paper rejected.