JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: Extending JumpProcess.jl for fast point process simulation with time-varying intensities #132

Closed whedon closed 10 months ago

whedon commented 10 months ago

Submitting author: @gzagatti (Guilherme Augusto Zagatti) Repository: https://github.com/SciML/JumpProcesses.jl Version: Editor: @matbesancon Reviewers: @gdalle Managing EiC: Mathieu Besançon

Author instructions

Thanks for submitting your paper to JCON @gzagatti. Currently, there isn't an JCON editor assigned to your paper.

The author's suggestion for the handling editor is @matbesancon.

@gzagatti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JCON and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JCON submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 10 months ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
matbesancon commented 10 months ago

@whedon generate pdf from branch juliacon2023

whedon commented 10 months ago
Attempting PDF compilation from custom branch juliacon2023. Reticulating splines etc...
whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Can't find any papers to compile :-(
whedon commented 10 months ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.13 s (707.3 files/s, 95448.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           68           1256            703           7287
Markdown                        13            601              0           2415
YAML                             8             12              8            183
TOML                             3              5              0             67
TeX                              1              0              0             13
-------------------------------------------------------------------------------
SUM:                            93           1874            711           9965
-------------------------------------------------------------------------------

Statistical information for the repository 'b30a4e14d01c08ed7f43aea7' was
gathered on 2023/08/17.
No commited files with the specified extensions were found.
whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
===========Latexmk: Missing input file: 'stackengine.sty' from line
  '! LaTeX Error: File `stackengine.sty' not found.'
Latexmk: Missing input file: 'stackengine.sty' from line
  '! LaTeX Error: File `stackengine.sty' not found.'
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
matbesancon commented 10 months ago

@gzagatti not sure what stackengine is but you'll probably need the sty library added to the repo

gzagatti commented 10 months ago

@whedon commands

whedon commented 10 months ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
gzagatti commented 10 months ago

@whedon generate pdf from commit 68f25fa51b02920410600cd48e0a401f3454f787

whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Can't find any papers to compile :-(
matbesancon commented 10 months ago

I think your commit needs to be on the same repo, not a fork

gzagatti commented 10 months ago

Ok, I don't have write access to the main repo. That's why I've opened a PR to get it merged to the paper branch.

I'm tagging @isaacsas who is the library maintainer so that he is aware of the review process here.

isaacsas commented 10 months ago

I merged your PR.

gzagatti commented 10 months ago

@whedon generate pdf from branch juliacon2023

whedon commented 10 months ago
Attempting PDF compilation from custom branch juliacon2023. Reticulating splines etc...
whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
===========Latexmk: Missing input file: 'subfig.sty' from line
  '! LaTeX Error: File `subfig.sty' not found.'
Latexmk: Missing input file: 'subfig.sty' from line
  '! LaTeX Error: File `subfig.sty' not found.'
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
gzagatti commented 10 months ago

@matbesancon compilation failed again because of the missing subfig.sty package.

Would it be possible to share the docker container (or at least the compilation env) of the LaTex compiler such that I can ensure that the repo will build against it?

matbesancon commented 10 months ago

unfortunately the compilation env is a bit opaque, the easiest for now is to include the package you are missing

gzagatti commented 10 months ago

@whedon generate pdf from branch juliacon2023

whedon commented 10 months ago
Attempting PDF compilation from custom branch juliacon2023. Reticulating splines etc...
whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
===========Latexmk: Missing input file: 'multirow.sty' from line
  '! LaTeX Error: File `multirow.sty' not found.'
Latexmk: Missing input file: 'multirow.sty' from line
  '! LaTeX Error: File `multirow.sty' not found.'
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
gzagatti commented 10 months ago

@whedon generate pdf from branch juliacon2023

whedon commented 10 months ago
Attempting PDF compilation from custom branch juliacon2023. Reticulating splines etc...
whedon commented 10 months ago

PDF failed to compile for issue #132 with the following error:

 Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55.
Rule 'pdflatex': Rules & subrules not known to be previously run:
   pdflatex
Rule 'pdflatex': The following rules & subrules became out-of-date:
      'pdflatex'
------------
Run number 1 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  "paper.tex"'
------------
===========Latexmk: Missing input file: 'mhsetup.sty' from line
  '! LaTeX Error: File `mhsetup.sty' not found.'
Latexmk: Missing input file: 'mhsetup.sty' from line
  '! LaTeX Error: File `mhsetup.sty' not found.'
Failure to make 'paper.pdf'
Collected error summary (may duplicate other messages):
  pdflatex: Command for 'pdflatex' gave return code 1
      Refer to 'paper.log' for details
Looks like we failed to compile the PDF
gzagatti commented 10 months ago

@whedon generate pdf from branch juliacon2023

whedon commented 10 months ago
Attempting PDF compilation from custom branch juliacon2023. Reticulating splines etc...
whedon commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

matbesancon commented 10 months ago

@gzagatti let us know when the paper is ready to continue with the submission

gzagatti commented 10 months ago

@matbesancon it's all good to proceed. The paper compiled correctly.

matbesancon commented 10 months ago

@whedon add @gdalle as reviewer

whedon commented 10 months ago

You need to assign an editor first.

gzagatti commented 10 months ago

@matbesancon it looks like your previous command failed, as an editor needs to be assigned first. Do I need to take any action?

matbesancon commented 10 months ago

@whedon add @matbesancon as editor

whedon commented 10 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
matbesancon commented 10 months ago

@whedon set @matbesancon as editor

whedon commented 10 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
matbesancon commented 10 months ago

@whedon commands

whedon commented 10 months ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# All commands can be run on a non-default branch, to do this pass a custom 
# branch name by following the command with `from branch custom-branch-name`.
# For example:

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a dry run of accepting the paper and depositing with Crossref
@whedon recommend-accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true
matbesancon commented 10 months ago

@whedon assign @matbesancon as editor

whedon commented 10 months ago

OK, the editor is @matbesancon

matbesancon commented 10 months ago

@whedon add @gdalle as reviewer

whedon commented 10 months ago

OK, @gdalle is now a reviewer

matbesancon commented 10 months ago

@whedon start review

whedon commented 10 months ago

OK, I've started the review over in https://github.com/JuliaCon/proceedings-review/issues/133.