JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: EditorialBot testing #143

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@luraess<!--end-author-handle-- (Ludovic Räss) Repository: https://github.com/luraess/JuliaConSubmission.jl Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: !--editor-->@lucaferranti<!--end-editor-- Reviewers: @arfon, @matbesancon Managing EiC: Luca Ferranti

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f"><img src="https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f/status.svg)](https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f)

Author instructions

Thanks for submitting your paper to JCON @luraess. Currently, there isn't a JCON editor assigned to your paper.

@luraess if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JCON submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (920.2 files/s, 216248.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            271            194           2693
Ruby                             1              8              4             45
Markdown                         1             12              0             29
YAML                             1              0              0             13
TOML                             1              2              0              8
Julia                            2              3              1              7
-------------------------------------------------------------------------------
SUM:                            14            296            199           2795
-------------------------------------------------------------------------------

Commit count by author:

    13  Mathieu Besançon
     2  Christian Schilling
     2  Jeffrey Sarnoff
     2  Valentin Churavy
     1  Benoît Legat
     1  Carsten Bauer
     1  Hendrik Ranocha
     1  Jorge Pérez Zerpa
     1  Ludovic Räss
     1  Patrick Altmeyer
     1  Simon Byrne
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1287/opre.38.5.911 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.tex is 2185

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

lucaferranti commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

@editorialbot add @matbesancon as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

@arfon @xuanxu any idea why editorialbot does not recognize my authority? I should be in editorial board: https://proceedings.juliacon.org/about

arfon commented 3 months ago

@lucaferranti editorial permissions are determined by GitHub team membership (not by the proceedings website). @xuanxu can you remind me how we figure out which team this is?

lucaferranti commented 3 months ago

I thought the proceedings website reads the info from the same github team though?

maybe some typos in the team name somewhere?

arfon commented 3 months ago

@editorialbot list editors

editorialbot commented 3 months ago

List of JuliaCon editors

@arfon
@fcdimitr
@lucaferranti
@luraess
@matbesancon
@odow
@pitsianis
arfon commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

This is very weird... Can you try again @lucaferranti?

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

@arfon yep doesn't work :(

lucaferranti commented 3 months ago

mmm I think I found the issue, here: https://github.com/openjournals/buffy/blob/juliacon/config/settings-production.yml#L9-L10

  teams:
    editors: JuliaCon/jcon-editors
    eics: JuliaCon/jcon-eics

but I believe the first team-name should be editors?

lucaferranti commented 3 months ago

@whedon add @lucaferranti as editor

editorialbot commented 3 months ago

My name is now @editorialbot

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

damn, I tried changing the team name from Editors to jcon-editors to match the name in the settingsn, but didn't seem to work

lucaferranti commented 3 months ago

@editorialbot list editors

editorialbot commented 3 months ago

List of JuliaCon editors


The list is empty```
lucaferranti commented 3 months ago

@editorialbot list editors

editorialbot commented 3 months ago

List of JuliaCon editors

@arfon
@fcdimitr
@lucaferranti
@luraess
@matbesancon
@odow
@pitsianis
lucaferranti commented 3 months ago

ok now I am a bit confused

the config has

editors: JuliaCon/jcon-editors

and that actually seems to work since @editorialbot list editors works. This is trange, because jcon-editors is not the name of the team https://github.com/orgs/JuliaCon/teams/editors and changing the name of the team to jcon-editors actually breaks things.

Now I am starting to think that the issue is with the eic team, since effectively assigning the editor is an EiC task.

A few observations:

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

@editorialbot list editors

editorialbot commented 3 months ago

List of JuliaCon editors

@arfon
@fcdimitr
@lucaferranti
@luraess
@matbesancon
@odow
@pitsianis
lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

lucaferranti commented 3 months ago

ok, I gave the jcon-eics team write access ot this and the papers repository (second last attempt) but didn't work.

Then I thought, maybe I need to remove the jcon- from the name (for analogy with JuliaCon/jcon-editors working despite the team is JuliaCon/editors) so I tried to rename the team to simply eics but didn't help.

xuanxu commented 3 months ago

Hi! You are mixing two different things here. The teams that are authorized to do things are the ones configured under the "teams" key in line 9 of the config file. The list of people you get when running the "list editors" command comes from a responder made to list members of a team, and that is configured en line 35 of the production config file. Right now there are two different named in those places. (sorry by my slow anwsers, i'm on a trip without my laptop and poor internet)

lucaferranti commented 3 months ago

a-haa thank you @xuanxu , that's what tricked me before.

I opened a PR to buffy to udpate the correct team name: https://github.com/openjournals/buffy/pull/104

lucaferranti commented 3 months ago

@editorialbot list reviewers

editorialbot commented 3 months ago

You can take a look at the list of people that have already agreed to review for JCON here.

lucaferranti commented 3 months ago

@editorialbot list reviewers

editorialbot commented 3 months ago

You can take a look at the list of people that have already agreed to review for JCON here.

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as editor

editorialbot commented 3 months ago

Assigned! @lucaferranti is now the editor

lucaferranti commented 3 months ago

@editorialbot add @arfon as reviewer

editorialbot commented 3 months ago

@arfon added to the reviewers list!

lucaferranti commented 3 months ago

@editorialbot add @lucaferranti as reviewer