search

JuliaCon / proceedings-review

7 stars 1 forks source link

[REVIEW]: Simulation of fracture and damage with Peridynamics.jl #165

Closed editorialbot closed 1 week ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@kaipartmann<!--end-author-handle-- (Kai Partmann) Repository: https://github.com/kaipartmann/Peridynamics.jl Branch with paper.md (empty if default branch): paper_juliacon_2023 Version: v0.3.3 Editor: !--editor-->@luraess<!--end-editor-- Reviewers: @ranocha, @ZenanH Archive: 10.5281/zenodo.13757260

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/b5f2635daed8de1734d967149f046ee4"><img src="https://proceedings.juliacon.org/papers/b5f2635daed8de1734d967149f046ee4/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/b5f2635daed8de1734d967149f046ee4/status.svg)](https://proceedings.juliacon.org/papers/b5f2635daed8de1734d967149f046ee4)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ranocha & @HaoZeke, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @luraess know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ranocha

📝 Checklist for @ZenanH

editorialbot commented 3 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1007/s42102-018-0004-x is OK
- 10.3934/matersci.2022049 is OK
- 10.1002/pamm.202200217 is OK
- 10.1016/j.jmps.2019.06.016 is OK
- 10.1177/1081286518803411 is OK
- 10.21105/joss.03020 is OK
- 10.1016/j.tafmec.2010.08.001 is OK
- 10.1007/978-1-4614-8465-3 is OK
- 10.1007/s10704-023-00726-7 is OK
- 10.1007/s42102-023-00100-0 is OK
- 10.1016/j.cma.2021.114085 is OK
- 10.1016/S0022-5096(99)00029-0 is OK
- 10.1007/s10659-007-9125-1 is OK
- 10.1002/pamm.202200249 is OK
- 10.1007/s42102-019-00021-x is OK
- 10.1016/j.softx.2023.101322 is OK

MISSING DOIs

- No DOI given, and none found for title: Peridynamic computations of wave propagation and r...
- No DOI given, and none found for title: Peridynamic computations for thin elastic rods

INVALID DOIs

- None
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (806.4 files/s, 223665.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            251            194           2470
Ruby                             1              8              4             45
Markdown                         1             20              0             37
YAML                             1              0              0             22
-------------------------------------------------------------------------------
SUM:                            11            279            198           2574
-------------------------------------------------------------------------------

Commit count by author:

   292  Kai Partmann
   126  kfrb
    36  kaipartmann
    27  Manuel Dienst
     4  =
     2  CompatHelper Julia
     2  K. Weinberg
     1  Kerstin Weinberg
     1  dependabot[bot]
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.tex is 927

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ranocha commented 2 months ago

Review checklist for @ranocha

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Paper format

Content

ranocha commented 2 months ago

I have created the issues https://github.com/kaipartmann/Peridynamics.jl/issues/167 and https://github.com/kaipartmann/Peridynamics.jl/issues/168 for this review. I think the paper can be accepted after major revisions.

luraess commented 2 months ago

Thanks @ranocha for providinga review of the article draft. A minor remark wrt the "statement of need"; we are currently revising the guidelines for that and do no longer require an explicit section about it. We leave it up to the authors to state and motivate where appropriate the need for their work.

kaipartmann commented 1 month ago

Hello together, I made some changes addressing the review comments in https://github.com/kaipartmann/Peridynamics.jl/issues/168. Again, thank you for the valuable feedback! @ranocha, @HaoZeke, please let me know if you have further remarks on these changes.

kaipartmann commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

luraess commented 1 month ago

@HaoZeke - when you find some time, and ideally in the coming two weeks, please generate your reviewer checklist and provide some feedback regarding the manuscript submission such that we do not stall the revision process 🙏

ranocha commented 1 month ago

https://github.com/kaipartmann/Peridynamics.jl/issues/167 is close to be closed. When that's done, a new release has been made, and the paper branch has been updated, I am fine accepting the paper. Thanks to @kaipartmann and collaborators for a nice contribution to the open-source ecosystem 👍

luraess commented 1 month ago

@HaoZeke please give any update, whether you want to (i) continue the revision process (and in this case ideally do it asap), or (ii) drop out. Both are fine, but please respond such that we could take further actions accordingly. Thank you!

luraess commented 1 month ago

Thanks for providing your feedback @ranocha ! Let's wait on @HaoZeke 's reply to further proceed.

kaipartmann commented 1 month ago

I closed the issue and included the current release in the paper branch. Thanks to @ranocha, for your help and invaluable feedback!

kaipartmann commented 1 month ago

@editorialbot set v0.3.3 as version

editorialbot commented 1 month ago

I'm sorry @kaipartmann, I'm afraid I can't do that. That's something only editors are allowed to do.

kaipartmann commented 1 month ago

@luraess, I've updated the software version. Please use the editorial bot command to update it. It seems only you have the permission to do so. Thank you!

luraess commented 1 month ago

@editorialbot set v0.3.3 as version

editorialbot commented 1 month ago

Done! version is now v0.3.3

luraess commented 4 weeks ago

@HaoZeke given that I did not hear anything back from you, I will remove you as reviewer for this submission.

luraess commented 4 weeks ago

@editorialbot commands

editorialbot commented 4 weeks ago

Hello @luraess, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set juliacon-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Reject paper
@editorialbot reject

# Withdraw paper
@editorialbot withdraw

# Invite an editor to edit a submission (sending them an email)
@editorialbot invite @(.*) as editor

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Accept and publish the paper
@editorialbot accept

# Update data on an accepted/published paper
@editorialbot reaccept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review
luraess commented 4 weeks ago

@editorialbot remove @HaoZeke from reviewers

editorialbot commented 4 weeks ago

@HaoZeke removed from the reviewers list!

luraess commented 4 weeks ago

@kaipartmann would you be able to provide me a short list of potential reviewers given that I had to drop one. Given the detailed review provided by @ranocha a second review would most likely be swiftly completed.

luraess commented 2 weeks ago

@editorialbot set 10.5281/zenodo.13757260 as archive

editorialbot commented 2 weeks ago

Done! archive is now 10.5281/zenodo.13757260

luraess commented 2 weeks ago

@editorialbot add @ZenanH as reviewer

editorialbot commented 2 weeks ago

@ZenanH added to the reviewers list!

ZenanH commented 2 weeks ago

Review checklist for @ZenanH

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Paper format

Content

luraess commented 2 weeks ago

@editorialbot recommend-accept

editorialbot commented 2 weeks ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 weeks ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1137/141000671 is OK
- 10.1007/s42102-018-0004-x is OK
- 10.3934/matersci.2022049 is OK
- 10.1002/pamm.202200217 is OK
- 10.1016/j.jmps.2019.06.016 is OK
- 10.1177/1081286518803411 is OK
- 10.21105/joss.03020 is OK
- 10.1016/j.tafmec.2010.08.001 is OK
- 10.1007/978-1-4614-8465-3 is OK
- 10.1007/s10704-023-00726-7 is OK
- 10.1007/s00419-024-02646-x is OK
- 10.1007/s42102-023-00100-0 is OK
- 10.1016/j.cma.2021.114085 is OK
- 10.1016/S0022-5096(99)00029-0 is OK
- 10.1007/s10659-007-9125-1 is OK
- 10.1002/pamm.202200249 is OK
- 10.1007/s42102-019-00021-x is OK
- 10.1016/j.softx.2023.101322 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Peridynamic computations for thin elastic rods

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
luraess commented 2 weeks ago

@editorialbot generate pdf

editorialbot commented 2 weeks ago

:wave: @JuliaCon/jcon-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/JuliaCon/proceedings-papers/pull/100, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

luraess commented 2 weeks ago

@kaipartmann from my side all looks good regarding accepting your paper. Please download the final proof and let mw know if all looks good to you. Please take care to check whether typesetting has no issues. After that, we could publish the paper. Thanks!

kaipartmann commented 2 weeks ago

Hello @luraess, Thank you very much for your help and support! We checked the proof and fixed one minor typo. Now, everything looks good except for one minor issue regarding the references. We just accepted the proofs of the article in ref. [14] and now know what DOI the article will have. Should we update the bib file, or will this result in an invalid DOI? I think the article of ref. [14] will be published in the next few days.

luraess commented 2 weeks ago

Hey, can you please try updating the .bib file and generate pdf again to see if it builds as expected.

kaipartmann commented 1 week ago

@editorialbot generate pdf

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kaipartmann commented 1 week ago

@editorialbot check references

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1137/141000671 is OK
- 10.1007/s42102-018-0004-x is OK
- 10.3934/matersci.2022049 is OK
- 10.1002/pamm.202200217 is OK
- 10.1016/j.jmps.2019.06.016 is OK
- 10.1177/1081286518803411 is OK
- 10.21105/joss.03020 is OK
- 10.1016/j.tafmec.2010.08.001 is OK
- 10.1007/978-1-4614-8465-3 is OK
- 10.1007/s10704-023-00726-7 is OK
- 10.1007/s00419-024-02646-x is OK
- 10.1007/s42102-023-00100-0 is OK
- 10.1016/j.cma.2021.114085 is OK
- 10.1016/S0022-5096(99)00029-0 is OK
- 10.1007/s10659-007-9125-1 is OK
- 10.1002/pamm.202200249 is OK
- 10.1007/s42102-019-00021-x is OK
- 10.1016/j.softx.2023.101322 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 10.1002/pamm.202400103 is INVALID
kaipartmann commented 1 week ago

@luraess The PDF looks good, but as expected, the DOI is invalid as it is only visible to me in the Proofing System of the article.

luraess commented 1 week ago

I see. Thanks. If you expect the DOI to become available in the coming days, could we wait and then publish this one. If not, let mw know about an alternative option and we could follow it as well.

kaipartmann commented 1 week ago

@editorialbot check references

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1137/141000671 is OK
- 10.1007/s42102-018-0004-x is OK
- 10.3934/matersci.2022049 is OK
- 10.1002/pamm.202200217 is OK
- 10.1016/j.jmps.2019.06.016 is OK
- 10.1177/1081286518803411 is OK
- 10.21105/joss.03020 is OK
- 10.1016/j.tafmec.2010.08.001 is OK
- 10.1007/978-1-4614-8465-3 is OK
- 10.1007/s10704-023-00726-7 is OK
- 10.1007/s00419-024-02646-x is OK
- 10.1002/pamm.202400103 is OK
- 10.1007/s42102-023-00100-0 is OK
- 10.1016/j.cma.2021.114085 is OK
- 10.1016/S0022-5096(99)00029-0 is OK
- 10.1007/s10659-007-9125-1 is OK
- 10.1002/pamm.202200249 is OK
- 10.1007/s42102-019-00021-x is OK
- 10.1016/j.softx.2023.101322 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
kaipartmann commented 1 week ago

@luraess The other article is published now and all DOIs are OK. I think the paper is ready for publication.

Thank you very much for your help and support during this review process!