JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: Interoperating Deep Learning models with ONNX.jl #21

Closed whedon closed 3 years ago

whedon commented 4 years ago

Submitting author: @ayush-1506 (Ayush Shridhar) Repository: https://github.com/FluxML/ONNX.jl Editor: @vchuravy Reviewers: @ekinakyurek, @NiklasGustafsson

Author instructions

Thanks for submitting your paper to JuliaCon @ayush-1506. The JuliaCon editor @vchuravy, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@ayush-1506 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JuliaCon and may be suitable for this submission.

Editor instructions

The JuliaCon submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @vchuravy it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@vchuravy) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #21 with the following error:

rm: cannot remove '*.aux': No such file or directory Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55. Rule 'pdflatex': Rules & subrules not known to be previously run: pdflatex Rule 'pdflatex': The following rules & subrules became out-of-date: 'pdflatex'

Run number 1 of rule 'pdflatex'


Running 'pdflatex -recorder "paper.tex"'

Latexmk: List of undefined refs and citations: Citation CuArrays' on page 1 undefined on input line 14 CitationDBLP:journals/corr/abs-1810-07951' on page 1 undefined on input line 14 Citation besard:2017' on page 1 undefined on input line 14 Citationbezanson2017julia' on page 1 undefined on input line 14 Citation `innes:2018' on page 1 undefined on input line 14 Latexmk: Summary of warnings: Latex failed to resolve 5 citation(s) Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux'

Run number 2 of rule 'pdflatex'


Running 'pdflatex -recorder "paper.tex"'

Latexmk: List of undefined refs and citations: Citation CuArrays' on page 1 undefined on input line 14 CitationDBLP:journals/corr/abs-1810-07951' on page 1 undefined on input line 14 Citation besard:2017' on page 1 undefined on input line 14 Citationbezanson2017julia' on page 1 undefined on input line 14 Citation `innes:2018' on page 1 undefined on input line 14 Latexmk: Summary of warnings: Latex failed to resolve 5 citation(s) Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.out'

Run number 3 of rule 'pdflatex'


Running 'pdflatex -recorder "paper.tex"'

Latexmk: List of undefined refs and citations: Citation CuArrays' on page 1 undefined on input line 14 CitationDBLP:journals/corr/abs-1810-07951' on page 1 undefined on input line 14 Citation besard:2017' on page 1 undefined on input line 14 Citationbezanson2017julia' on page 1 undefined on input line 14 Citation `innes:2018' on page 1 undefined on input line 14 Latexmk: Summary of warnings: Latex failed to resolve 5 citation(s) Failure to make 'paper.pdf' Collected error summary (may duplicate other messages): pdflatex: Command for 'pdflatex' gave return code 1 Refer to 'paper.log' for details Looks like we failed to compile the PDF

vchuravy commented 4 years ago

@whedon commands

vchuravy commented 4 years ago

@NiklasGustafsson would you be interested in reviewing this paper? https://proceedings.juliacon.org/guide/reviewers/

vchuravy commented 4 years ago

@whedon add @ekinakyurek as reviewer

whedon commented 4 years ago

OK, @ekinakyurek is now a reviewer

vchuravy commented 4 years ago

@ayush-1506 please make sure that your submission compiles with whedon

NiklasGustafsson commented 4 years ago

Sure, I can help review.

vchuravy commented 4 years ago

@whedon add @NiklasGustafsson as reviewer

whedon commented 4 years ago

OK, @NiklasGustafsson is now a reviewer

vchuravy commented 4 years ago

Thank you. As soon as Ayush has fixed the paper I will start the review process.

Take a look at https://proceedings.juliacon.org/guide/reviewers/ in the meanwhile and I am happy to answer questions.

ayush-1506 commented 4 years ago

@vchuravy Thanks a lot. I'll be targeting the special edition, not the JuliaCon proceedings, since I wasn't able to make it to JuliaCon this year (I created this before knowing that I wasn't going to make it). Should I keep this open, or move it to another repository for the special edition?

vchuravy commented 4 years ago

@ayush-1506 since you were accepted to JuliaCon, but couldn't make it for unrelated reasons it is up to you if you want to submit this to the proceedings or the special edition. In either case the submission process is the same and I would encourage you to finish it up as soon as possible, since we already have reviewers. Both proceedings and special edition are rolling submission.

ayush-1506 commented 4 years ago

@vchuravy Thanks, will probably finish this up in the upcoming week. I'd prefer submitting to the JuliaCon proceedings in this case.

vchuravy commented 4 years ago

@ayush-1506 I have moved this from the proceedings to the planned special issue. This should give you a bit more time to finish up things.

ayush-1506 commented 4 years ago

@vchuravy Thanks, apologies for the delay. I'm finishing this up at the moment. Could you give me an ETA on the special edition submission?

ayush-1506 commented 4 years ago

@whedon commands

whedon commented 4 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references
ayush-1506 commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ayush-1506 commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ayush-1506 commented 4 years ago

@NiklasGustafsson Could you please review this?

NiklasGustafsson commented 4 years ago

Will do.

NiklasGustafsson commented 4 years ago

What is the preferred mechanism for providing my feedback?

ayush-1506 commented 4 years ago

@NiklasGustafsson I reckon it's best we do this on slack (in case you're on julialang slack), or via mail. Does that sound good?

NiklasGustafsson commented 4 years ago

I'm not on the JuliaLang Slack channel. You can contact me at niklas.gustafsson@microsoft.com, so I'll have your email address. Once I have that, I will send you some thoughts.

ayush-1506 commented 4 years ago

Ok, I've sent you a mail.

vchuravy commented 4 years ago

@ayush-1506 @NiklasGustafsson how did the review go?

vchuravy commented 3 years ago

@whedon start review

NiklasGustafsson commented 3 years ago

I forwarded my comments via email back in the winter.

vchuravy commented 3 years ago

@whedon commands

whedon commented 3 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# All commands can be run on a non-default branch, to do this pass a custom 
# branch name by following the command with `from branch custom-branch-name`.
# For example:

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a dry run of accepting the paper and depositing with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true
vchuravy commented 3 years ago

@whedon start review

vchuravy commented 3 years ago

@NiklasGustafsson thank you for that! I talked to Ayush offline and he will integrate them and then we can move forward.

arfon commented 3 years ago

@whedon start review

arfon commented 3 years ago

@whedon start review

arfon commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/JuliaCon/proceedings-review/issues/59.