JuliaCon / proceedings-review

6 stars 1 forks source link

[PRE REVIEW]: Probabilistic Biostatistics with Julia #25

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @tszanalytics (Jeffrey A Mills) Repository: https://github.com/tszanalytics/Juliacon2019/ Editor: @matbesancon Reviewers: @bkamins, @kescobo

Author instructions

Thanks for submitting your paper to JuliaCon @tszanalytics. The JuliaCon editor @matbesancon, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@tszanalytics if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JuliaCon and may be suitable for this submission.

Editor instructions

The JuliaCon submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @matbesancon it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@matbesancon) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #25 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/25 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:incollect!' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:61:infind_paper_paths' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:116:in<top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

tszanalytics commented 4 years ago

@whedon commands

whedon commented 4 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references
tszanalytics commented 4 years ago

@matbesancon Here's suggestions from the list of potential reviewers (starting at bottom of list) :

dmbates dmbates@gmail.com kescobo kevbonham@gmail.com bkamins bkamins@sgh.waw.pl

Also, the paper did not appear to compile due to a missing file. I will see if I can fix that. Thanks!

matbesancon commented 4 years ago

Thanks @tszanalytics, note that we cannot start the review while the paper doesn't compile. @bkamins would you be available to review this proceeding?

matbesancon commented 4 years ago

@kescobo would you be available to review?

bkamins commented 4 years ago

@matbesancon - sure - I can help. What would be the process?

matbesancon commented 4 years ago

the review happens in an issue, you provide feedback on the code and paper, can submit issues on the main repo itself, changes can happen gradually. Once the checklist is done and you are satisfied with everything, the review is done

See https://github.com/JuliaCon/proceedings-review/issues/28 for instance

matbesancon commented 4 years ago

@whedon add @bkamins as reviewer

whedon commented 4 years ago

OK, @bkamins is now a reviewer

tszanalytics commented 4 years ago

@matbesancon Hi, sorry I don't know what I need to change to get the paper to compile. I'm unfamiliar with Ruby and latexmk. Do I need to install these on my local machine or is there a way to compile without doing so, and if so how? Thanks!

matbesancon commented 4 years ago

The URL you provided is not in the correct format, it should be the main repo, not the path to the paper file

bkamins commented 4 years ago

@matbesancon: I understand that I wait till the status changes to [REVIEW] and the paper PDF is generated + the list like in #28 is in place. Right?

@tszanalytics: I think it will be easier if I give you the feedback as new issues in https://github.com/tszanalytics/Juliacon2019. OK? Also can you also please guide me where are the runnable codes for your text, as I could not find them in your repository. Finally there are two .tex files in the repo. I understand that one can be removed - right?.

matbesancon commented 4 years ago

I understand that I wait till the status changes to [REVIEW] and the paper PDF is generated + the list like in #28 is in place. Right?

You can start your review now by posting issues on the main repo yes, but this one will likely be closed since the URL is invalid. Once we have a second reviewer, I'll open the review issue exactly

matbesancon commented 4 years ago

@tszanalytics you should submit with https://github.com/tszanalytics/Juliacon2019 as repository if it is your main repo

kescobo commented 4 years ago

I'd love to review, but I'm fairly strapped for time (and off the grid for a week starting Friday). What's the time frame?

matbesancon commented 4 years ago

This would be fine, @bkamins can start the review and you can pick up after you come back

tszanalytics commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #25 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/25 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:incollect!' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:61:infind_paper_paths' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:116:in<top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

matbesancon commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

matbesancon commented 4 years ago

@whedon add @kescobo as reviewer

whedon commented 4 years ago

OK, @kescobo is now a reviewer

matbesancon commented 4 years ago

@tszanalytics problem fixed :)

matbesancon commented 4 years ago

@whedon start review

tszanalytics commented 4 years ago

@matbesancon Ok, I withdrew and resubmitted using the URL as suggested. It compiled OK this time, thanks for the help!

@bkamins Thanks for agreeing to review my paper. I've removed the additional tex and pdf files from the \paper folder. I just have code snippets in the paper, but I can post more complete runnable examples of julia code and add the URL to the paper. I will do so asap. Let me know if you have anything in particular in mind. Also, giving feedback as an issue on the paper repo would be great. Thanks!

bkamins commented 4 years ago

@tszanalytics I asked about the codes, because if you look at https://github.com/JuliaCon/proceedings-review/issues/28 for example there are the following criteria that the paper must meet (I am copying the relevant ones from General checks, but please review all of them there to make sure that your submission complies with it):

General checks

bkamins commented 4 years ago

@matbesancon - I can see that you have started the review, but the "checklist" has not generated yet. Should I wait for it or I have missed something.

@tszanalytics - I can review the paper as is if you prefer not to add working codes to the repository. Please let me know how you see this.

matbesancon commented 4 years ago

thanks for the ping, it hasn't started indeed

matbesancon commented 4 years ago

@whedon start review

matbesancon commented 4 years ago

@whedon commands

whedon commented 4 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to accept the paper and deposit with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references
matbesancon commented 4 years ago

@whedon start review

matbesancon commented 4 years ago

@arfon not sure why whedon isn't kicking off the review?

arfon commented 4 years ago

@matbesancon - it's showing up as withdrawn on the proceedings site. Is this incorrect?

matbesancon commented 4 years ago

ah point, sorry yup

tszanalytics commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

tszanalytics commented 4 years ago

@matbesancon @bkamins @kescobo

Ok, I believe it is ready to move forward with review now. I've added code to generate the figures, etc. that appear in the paper, as well as code for some of the additional examples in the presentation. Let me know what else needs to be done and I should be able to complete quickly.

Thanks, Jeff

kescobo commented 4 years ago

So why was the issue closed? I'm so confused...

bkamins commented 4 years ago

This one should be used: https://github.com/JuliaCon/proceedings-review/issues/36. @tszanalytics - I am not sure but probably you should re-generate the PDF in #36

matbesancon commented 4 years ago

Indeed that is in #36