[REVIEW]: Modia3D: Modeling and Simulation of 3D-Systems in Julia

whedon commented 5 years ago

Submitting author: !--author-handle-->@MartinOtter@matbesancon<!--end-editor-- Reviewers: @Datseris, @dawbarton Archive:

Status

Status badge code:

HTML: <a href="https://submissions.juliacon.org/papers/16d9193656436b4d4f774f73ab34d8c5"><img src="https://submissions.juliacon.org/papers/16d9193656436b4d4f774f73ab34d8c5/status.svg"></a>
Markdown: [![status](https://submissions.juliacon.org/papers/16d9193656436b4d4f774f73ab34d8c5/status.svg)](https://submissions.juliacon.org/papers/16d9193656436b4d4f774f73ab34d8c5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Datseris, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/JuliaCon/proceedings-reviews/invitations

The reviewer guidelines are available here: https://proceedings.juliacon.org/guide/reviewers. Any questions/concerns please let @matbesancon know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @Datseris

Conflict of interest

[x] As the reviewer I confirm that I have read the JuliaCon conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JuliaCon code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Authorship: Has the submitting author (@MartinOtter) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

[x] Authors: Does the paper.tex file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
[x] Page limit: Is the page limit for full papers respected by the submitted document?

Content

[x] Context: is the scientific context motivating the work correctly presented?
[x] Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
[x] Results: are the results presented and compared to approaches with similar goals?

Review checklist for @dawbarton

Conflict of interest

[x] As the reviewer I confirm that I have read the JuliaCon conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JuliaCon code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Authorship: Has the submitting author (@MartinOtter) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

[x] Authors: Does the paper.tex file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
[x] Page limit: Is the page limit for full papers respected by the submitted document?

Content

[x] Context: is the scientific context motivating the work correctly presented?
[x] Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
[x] Results: are the results presented and compared to approaches with similar goals?

whedon commented 4 years ago

PDF failed to compile for issue #43 with the following error:

rm: cannot remove '*.aux': No such file or directory Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55. Rule 'pdflatex': Rules & subrules not known to be previously run: pdflatex Rule 'pdflatex': The following rules & subrules became out-of-date: 'pdflatex'

Run number 1 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

Latexmk: Non-existent bbl file 'paper.bbl' No file paper.bbl. Latexmk: References changed. Latexmk: References changed. Latexmk: Log file says output to 'paper.pdf' Latexmk: List of undefined refs and citations: Citation `Elmqvist2015' on page 5 undefined on input line 338 Citation`Erez2015' on page 2 undefined on input line 11 Citation `Flores2011' on page 3 undefined on input line 164 Citation`Flores2011' on page 3 undefined on input line 193 Citation `Flores2011' on page 3 undefined on input line 197 Citation`Flores2011' on page 4 undefined on input line 238 Citation `GJK1988' on page 3 undefined on input line 118 Citation`Neumayr2017' on page 1 undefined on input line 44 Citation `Neumayr2017' on page 3 undefined on input line 119 Citation`Neumayr2017' on page 3 undefined on input line 132 Citation `Neumayr2018' on page 1 undefined on input line 11 Citation`Neumayr2018' on page 1 undefined on input line 43 Citation `Neumayr2018' on page 2 undefined on input line 66 Citation`Neumayr2019' on page 1 undefined on input line 44 Citation `Nystrom2014' on page 1 undefined on input line 10 Citation`Rackauckas2017' on page 1 undefined on input line 26 Citation `Rackauckas2017' on page 3 undefined on input line 107 Citation`Skinjar2018' on page 3 undefined on input line 164 Citation `Skinjar2018' on page 3 undefined on input line 201 Citation`Skinjar2018' on page 4 undefined on input line 238 Citation `Sundials2005' on page 1 undefined on input line 26 Citation`Sundials2005' on page 3 undefined on input line 106 Citation `bellmann2009' on page 1 undefined on input line 41 Citation`bergen2003' on page 3 undefined on input line 118 Citation `bergen2003' on page 3 undefined on input line 125 Citation`bergen2003' on page 5 undefined on input line 329 Citation `bezanson2017julia' on page 1 undefined on input line 7 Citation`hellerer2014' on page 1 undefined on input line 41 Citation `kenwright2015' on page 3 undefined on input line 119 Citation`otter2005' on page 3 undefined on input line 164 Citation `snethen2008' on page 3 undefined on input line 117 Citation`snethen2008' on page 3 undefined on input line 119 Reference `eq:DAE' on page 3 undefined on input line 101 Reference`eq:DAE' on page 3 undefined on input line 102 Reference `eq:DAE' on page 3 undefined on input line 105 Reference`eq:DAE' on page 3 undefined on input line 82 Reference `eq:DAE' on page 3 undefined on input line 84 Reference`eq:DAE' on page 5 undefined on input line 325 Reference `eq:response' on page 3 undefined on input line 163 Reference`eq:response' on page 3 undefined on input line 181 Reference `eq:response' on page 4 undefined on input line 215 Reference`eq:response' on page 4 undefined on input line 227 Reference `eq:response' on page 4 undefined on input line 232 Reference`eq:response' on page 4 undefined on input line 236 Reference `eq:response' on page 4 undefined on input line 281 Reference`fig:Fourbar' on page 2 undefined on input line 40 Reference `fig:bar' on page 2 undefined on input line 19 Reference`fig:billiardTable' on page 5 undefined on input line 6 Reference `fig:bouncingBall' on page 2 undefined on input line 37 Reference`fig:bouncingBall' on page 4 undefined on input line 221 Reference `fig:bouncingBall' on page 4 undefined on input line 227 Reference`fig:bouncingBallPlot' on page 4 undefined on input line 220 Reference `fig:forces' on page 3 undefined on input line 137 Reference`fig:forces' on page 3 undefined on input line 145 Reference `fig:rollingBall' on page 4 undefined on input line 242 Reference`fig:rollingBall_plot' on page 4 undefined on input line 264 Reference `fig:rollingBall_plot' on page 4 undefined on input line 265 Reference`fig:rollingBall_plot' on page 4 undefined on input line 280 Reference `fig:twoCollidingBalls' on page 4 undefined on input line 288 Reference`fig:twoCollidingBalls_plot' on page 4 undefined on input line 290 Reference `fig:twoCollidingBalls_plot' on page 4 undefined on input line 310 Reference`sec:numericSolution' on page 5 undefined on input line 324 Reference `sec:responseCalculation' on page 2 undefined on input line 34 Reference`sec:responseCalculation' on page 3 undefined on input line 112 Reference `sec:responseCalculation' on page 3 undefined on input line 136 Reference`sect_flexibleDefinition' on page 1 undefined on input line 38 Reference `table:ModiaPlatform' on page 1 undefined on input line 6 Reference`table:billiardTableMaterials' on page 4 undefined on input line 254 Reference `table:billiardTableMaterials' on page 5 undefined on input line 7 Latexmk: Found bibliography file(s) [ref.bib] Latexmk: Summary of warnings: Latex failed to resolve 40 reference(s) Latex failed to resolve 33 citation(s) Rule 'bibtex paper': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' Non-existent destination files: 'paper.bbl'

Run number 1 of rule 'bibtex paper'

Running 'bibtex "paper"'

Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' 'paper.bbl' 'paper.out'

Run number 2 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

Latexmk: Found input bbl file 'paper.bbl' Latexmk: References changed. Latexmk: References changed. Latexmk: Log file says output to 'paper.pdf' Latexmk: List of undefined refs and citations: Citation `Elmqvist2015' on page 5 undefined on input line 338 Citation`Erez2015' on page 2 undefined on input line 11 Citation `Flores2011' on page 3 undefined on input line 164 Citation`Flores2011' on page 3 undefined on input line 193 Citation `Flores2011' on page 3 undefined on input line 197 Citation`Flores2011' on page 4 undefined on input line 238 Citation `GJK1988' on page 3 undefined on input line 118 Citation`Neumayr2017' on page 1 undefined on input line 44 Citation `Neumayr2017' on page 3 undefined on input line 119 Citation`Neumayr2017' on page 3 undefined on input line 132 Citation `Neumayr2018' on page 1 undefined on input line 11 Citation`Neumayr2018' on page 1 undefined on input line 43 Citation `Neumayr2018' on page 2 undefined on input line 66 Citation`Neumayr2019' on page 1 undefined on input line 44 Citation `Nystrom2014' on page 1 undefined on input line 10 Citation`Rackauckas2017' on page 1 undefined on input line 26 Citation `Rackauckas2017' on page 3 undefined on input line 107 Citation`Skinjar2018' on page 3 undefined on input line 164 Citation `Skinjar2018' on page 3 undefined on input line 201 Citation`Skinjar2018' on page 4 undefined on input line 238 Citation `Sundials2005' on page 1 undefined on input line 26 Citation`Sundials2005' on page 3 undefined on input line 106 Citation `bellmann2009' on page 1 undefined on input line 41 Citation`bergen2003' on page 3 undefined on input line 118 Citation `bergen2003' on page 3 undefined on input line 125 Citation`bergen2003' on page 5 undefined on input line 329 Citation `bezanson2017julia' on page 1 undefined on input line 7 Citation`hellerer2014' on page 1 undefined on input line 41 Citation `kenwright2015' on page 3 undefined on input line 119 Citation`otter2005' on page 3 undefined on input line 164 Citation `snethen2008' on page 3 undefined on input line 117 Citation`snethen2008' on page 3 undefined on input line 119 Latexmk: Found bibliography file(s) [ref.bib] Latexmk: Summary of warnings: Latex failed to resolve 33 citation(s) Rule 'bibtex paper': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux'

Run number 2 of rule 'bibtex paper'

Running 'bibtex "paper"'

Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' 'paper.out'

Run number 3 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

Latexmk: Found input bbl file 'paper.bbl' Latexmk: Log file says output to 'paper.pdf' Latexmk: Found bibliography file(s) [ref.bib] /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/bibliography.rb:50:in read': No such file or directory @ rb_sysopen - tmp/43/paper/ref (Errno::ENOENT) from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/bibliography.rb:50:inopen' from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/utilities.rb:25:in open' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/bibtex_parser.rb:36:ingenerate_citations' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/compilers.rb:194:in crossref_from_latex' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/compilers.rb:19:ingenerate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/processor.rb:95:in compile' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/bin/whedon:82:incompile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/bin/whedon:119:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

AndreaNeumayr commented 4 years ago

👉 Check article proof 📄 👈

this looks fine. There are no problems with labels, references, and citations

matbesancon commented 4 years ago

indeed. @arfon do you know what the issue might be here?

matbesancon commented 4 years ago

@whedon accept from branch JuliaCon2019-paper

whedon commented 4 years ago

Attempting dry run of processing paper acceptance...

arfon commented 4 years ago

@whedon generate pdf from branch JuliaCon2019-paper

whedon commented 4 years ago

Attempting PDF compilation from custom branch JuliaCon2019-paper. Reticulating splines etc...

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

arfon commented 4 years ago

@whedon accept from branch JuliaCon2019-paper

whedon commented 4 years ago

Attempting dry run of processing paper acceptance...

arfon commented 4 years ago

@whedon accept from branch JuliaCon2019-paper

whedon commented 4 years ago

Attempting dry run of processing paper acceptance...

whedon commented 4 years ago

PDF failed to compile for issue #43 with the following error:

rm: cannot remove '*.aux': No such file or directory Latexmk: This is Latexmk, John Collins, 17 Jan. 2018, version: 4.55. Rule 'pdflatex': Rules & subrules not known to be previously run: pdflatex Rule 'pdflatex': The following rules & subrules became out-of-date: 'pdflatex'

Run number 1 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

kpathsea: Running mktexpk --mfmode / --bdpi 600 --mag 0+525/600 --dpi 525 ectt0800 mktexpk: Running mf-nowin -progname=mf \mode:=ljfour; mag:=0+525/600; nonstopmode; input ectt0800 This is METAFONT, Version 2.7182818 (TeX Live 2017) (preloaded base=mf)

(/app/.texlive/texmf-dist/fonts/source/jknappen/ec/ectt0800.mf (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exbase.mf) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/ectt.mf (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exroman.mf Ok (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exaccess.mf Ok) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/expseudo.mf Ok) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exruwest.mf Ok [192] [193] [194] [195] [196] [197] [198] [199] [200] [201] [202] [203] [204] [205] [206] [207] [208] [209] [210] [211] [212] [213] [214] [215] [216] [217] [218] [219] [220] [221] [222] [223]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrlwest.mf Ok [224] [225] [226] [227] [228] [229] [230] [231] [232] [233] [234] [235] [236] [237] [238] [239] [240] [241] [242] [243] [244] [245] [246] [247] [248] [249] [250] [251] [252] [253] [254] [255]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrueast.mf Ok [128] [129] [130] [131] [132] [133] [134] [135] [136] [137] [138] [139] [140] [141] [142] [143] [144] [145] [146] [147] [148] [149] [150] [151] [152] [153] [154] [155] [156] [157]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrleast.mf Ok [158] [160] [161] [162] [163] [164] [165] [166] [167] [168] [169] [170] [171] [172] [173] [174] [175] [176] [177] [178] [179] [180] [181] [182] [183] [184] [185] [186] [187] [188]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exbraces.mf Ok [94] [126] [23] [40] [41] [60] [124] [62] [91] [93] [92] [123] [125] [95] [127] [32]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/expunct.mf Ok [14] [15] [19] [20] [13] [18] [33] [39] [42] [43] [44] [46] [47] [58] [59] [61] [96] [189] [17] [45] [16] [21] [22]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exaccent.mf Ok [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exsign.mf Ok [24] [34] [35] [36] [37] [64] [191] [159]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrlig.mf Ok [25] [26] [28] [27] [29] [30] [31]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exromp.mf Ok [38] [63] [190]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrulett.mf Ok [65] [66] [67] [68] [69] [70] [71] [72] [73] [74] [75] [76] [77] [78] [79] [80] [81] [82] [83] [84] [85] [86] [87] [88] [89] [90]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrllett.mf Ok [97] [98] [99] [100] [101] [102] [103] [104] [105] [106] [107] [108] [109] [110] [111] [112] [113] [114] [115] [116] [117] [118] [119] [120] [121] [122]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrdigit.mf Ok [48] [49] [50] [51] [52] [53] [54] [55] [56] [57]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exmligtb.mf Ok) ) ) ) Font metrics written on ectt0800.tfm. Output written on ectt0800.525gf (256 characters, 31804 bytes). Transcript written on ectt0800.log. mktexpk: /app/.texlive/var/texmf-var/fonts/pk/ljfour/jknappen/ec/ectt0800.525pk: successfully generated.

kpathsea: Running mktexpk --mfmode / --bdpi 600 --mag 1+0/600 --dpi 600 ectt0900 mktexpk: Running mf-nowin -progname=mf \mode:=ljfour; mag:=1+0/600; nonstopmode; input ectt0900 This is METAFONT, Version 2.7182818 (TeX Live 2017) (preloaded base=mf)

(/app/.texlive/texmf-dist/fonts/source/jknappen/ec/ectt0900.mf (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exbase.mf) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/ectt.mf (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exroman.mf Ok (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exaccess.mf Ok) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/expseudo.mf Ok) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exruwest.mf Ok [192] [193] [194] [195] [196] [197] [198] [199] [200] [201] [202] [203] [204] [205] [206] [207] [208] [209] [210] [211] [212] [213] [214] [215] [216] [217] [218] [219] [220] [221] [222] [223]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrlwest.mf Ok [224] [225] [226] [227] [228] [229] [230] [231] [232] [233] [234] [235] [236] [237] [238] [239] [240] [241] [242] [243] [244] [245] [246] [247] [248] [249] [250] [251] [252] [253] [254] [255]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrueast.mf Ok [128] [129] [130] [131] [132] [133] [134] [135] [136] [137] [138] [139] [140] [141] [142] [143] [144] [145] [146] [147] [148] [149] [150] [151] [152] [153] [154] [155] [156] [157]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrleast.mf Ok [158] [160] [161] [162] [163] [164] [165] [166] [167] [168] [169] [170] [171] [172] [173] [174] [175] [176] [177] [178] [179] [180] [181] [182] [183] [184] [185] [186] [187] [188]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exbraces.mf Ok [94] [126] [23] [40] [41] [60] [124] [62] [91] [93] [92] [123] [125] [95] [127] [32]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/expunct.mf Ok [14] [15] [19] [20] [13] [18] [33] [39] [42] [43] [44] [46] [47] [58] [59] [61] [96] [189] [17] [45] [16] [21] [22]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exaccent.mf Ok [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exsign.mf Ok [24] [34] [35] [36] [37] [64] [191] [159]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrlig.mf Ok [25] [26] [28] [27] [29] [30] [31]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exromp.mf Ok [38] [63] [190]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrulett.mf Ok [65] [66] [67] [68] [69] [70] [71] [72] [73] [74] [75] [76] [77] [78] [79] [80] [81] [82] [83] [84] [85] [86] [87] [88] [89] [90]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrllett.mf Ok [97] [98] [99] [100] [101] [102] [103] [104] [105] [106] [107] [108] [109] [110] [111] [112] [113] [114] [115] [116] [117] [118] [119] [120] [121] [122]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exrdigit.mf Ok [48] [49] [50] [51] [52] [53] [54] [55] [56] [57]) (/app/.texlive/texmf-dist/fonts/source/jknappen/ec/exmligtb.mf Ok) ) ) ) Font metrics written on ectt0900.tfm. Output written on ectt0900.600gf (256 characters, 39464 bytes). Transcript written on ectt0900.log. mktexpk: /app/.texlive/var/texmf-var/fonts/pk/ljfour/jknappen/ec/ectt0900.600pk: successfully generated. Latexmk: Non-existent bbl file 'paper.bbl' No file paper.bbl. Latexmk: References changed. Latexmk: References changed. Latexmk: Log file says output to 'paper.pdf' Latexmk: List of undefined refs and citations: Citation `Elmqvist2015' on page 5 undefined on input line 338 Citation`Erez2015' on page 2 undefined on input line 11 Citation `Flores2011' on page 3 undefined on input line 164 Citation`Flores2011' on page 3 undefined on input line 193 Citation `Flores2011' on page 3 undefined on input line 197 Citation`Flores2011' on page 4 undefined on input line 238 Citation `GJK1988' on page 3 undefined on input line 118 Citation`Neumayr2017' on page 1 undefined on input line 44 Citation `Neumayr2017' on page 3 undefined on input line 119 Citation`Neumayr2017' on page 3 undefined on input line 132 Citation `Neumayr2018' on page 1 undefined on input line 11 Citation`Neumayr2018' on page 1 undefined on input line 43 Citation `Neumayr2018' on page 2 undefined on input line 66 Citation`Neumayr2019' on page 1 undefined on input line 44 Citation `Nystrom2014' on page 1 undefined on input line 10 Citation`Rackauckas2017' on page 1 undefined on input line 26 Citation `Rackauckas2017' on page 3 undefined on input line 107 Citation`Skinjar2018' on page 3 undefined on input line 164 Citation `Skinjar2018' on page 3 undefined on input line 201 Citation`Skinjar2018' on page 4 undefined on input line 238 Citation `Sundials2005' on page 1 undefined on input line 26 Citation`Sundials2005' on page 3 undefined on input line 106 Citation `bellmann2009' on page 1 undefined on input line 41 Citation`bergen2003' on page 3 undefined on input line 118 Citation `bergen2003' on page 3 undefined on input line 125 Citation`bergen2003' on page 5 undefined on input line 329 Citation `bezanson2017julia' on page 1 undefined on input line 7 Citation`hellerer2014' on page 1 undefined on input line 41 Citation `kenwright2015' on page 3 undefined on input line 119 Citation`otter2005' on page 3 undefined on input line 164 Citation `snethen2008' on page 3 undefined on input line 117 Citation`snethen2008' on page 3 undefined on input line 119 Reference `eq:DAE' on page 3 undefined on input line 101 Reference`eq:DAE' on page 3 undefined on input line 102 Reference `eq:DAE' on page 3 undefined on input line 105 Reference`eq:DAE' on page 3 undefined on input line 82 Reference `eq:DAE' on page 3 undefined on input line 84 Reference`eq:DAE' on page 5 undefined on input line 325 Reference `eq:response' on page 3 undefined on input line 163 Reference`eq:response' on page 3 undefined on input line 181 Reference `eq:response' on page 4 undefined on input line 215 Reference`eq:response' on page 4 undefined on input line 227 Reference `eq:response' on page 4 undefined on input line 232 Reference`eq:response' on page 4 undefined on input line 236 Reference `eq:response' on page 4 undefined on input line 281 Reference`fig:Fourbar' on page 2 undefined on input line 40 Reference `fig:bar' on page 2 undefined on input line 19 Reference`fig:billiardTable' on page 5 undefined on input line 6 Reference `fig:bouncingBall' on page 2 undefined on input line 37 Reference`fig:bouncingBall' on page 4 undefined on input line 221 Reference `fig:bouncingBall' on page 4 undefined on input line 227 Reference`fig:bouncingBallPlot' on page 4 undefined on input line 220 Reference `fig:forces' on page 3 undefined on input line 137 Reference`fig:forces' on page 3 undefined on input line 145 Reference `fig:rollingBall' on page 4 undefined on input line 242 Reference`fig:rollingBall_plot' on page 4 undefined on input line 264 Reference `fig:rollingBall_plot' on page 4 undefined on input line 265 Reference`fig:rollingBall_plot' on page 4 undefined on input line 280 Reference `fig:twoCollidingBalls' on page 4 undefined on input line 288 Reference`fig:twoCollidingBalls_plot' on page 4 undefined on input line 290 Reference `fig:twoCollidingBalls_plot' on page 4 undefined on input line 310 Reference`sec:numericSolution' on page 5 undefined on input line 324 Reference `sec:responseCalculation' on page 2 undefined on input line 34 Reference`sec:responseCalculation' on page 3 undefined on input line 112 Reference `sec:responseCalculation' on page 3 undefined on input line 136 Reference`sect_flexibleDefinition' on page 1 undefined on input line 38 Reference `table:ModiaPlatform' on page 1 undefined on input line 6 Reference`table:billiardTableMaterials' on page 4 undefined on input line 254 Reference `table:billiardTableMaterials' on page 5 undefined on input line 7 Latexmk: Found bibliography file(s) [ref.bib] Latexmk: Summary of warnings: Latex failed to resolve 40 reference(s) Latex failed to resolve 33 citation(s) Rule 'bibtex paper': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' Non-existent destination files: 'paper.bbl'

Run number 1 of rule 'bibtex paper'

Running 'bibtex "paper"'

Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' 'paper.bbl' 'paper.out'

Run number 2 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

Latexmk: Found input bbl file 'paper.bbl' Latexmk: References changed. Latexmk: References changed. Latexmk: Log file says output to 'paper.pdf' Latexmk: List of undefined refs and citations: Citation `Elmqvist2015' on page 5 undefined on input line 338 Citation`Erez2015' on page 2 undefined on input line 11 Citation `Flores2011' on page 3 undefined on input line 164 Citation`Flores2011' on page 3 undefined on input line 193 Citation `Flores2011' on page 3 undefined on input line 197 Citation`Flores2011' on page 4 undefined on input line 238 Citation `GJK1988' on page 3 undefined on input line 118 Citation`Neumayr2017' on page 1 undefined on input line 44 Citation `Neumayr2017' on page 3 undefined on input line 119 Citation`Neumayr2017' on page 3 undefined on input line 132 Citation `Neumayr2018' on page 1 undefined on input line 11 Citation`Neumayr2018' on page 1 undefined on input line 43 Citation `Neumayr2018' on page 2 undefined on input line 66 Citation`Neumayr2019' on page 1 undefined on input line 44 Citation `Nystrom2014' on page 1 undefined on input line 10 Citation`Rackauckas2017' on page 1 undefined on input line 26 Citation `Rackauckas2017' on page 3 undefined on input line 107 Citation`Skinjar2018' on page 3 undefined on input line 164 Citation `Skinjar2018' on page 3 undefined on input line 201 Citation`Skinjar2018' on page 4 undefined on input line 238 Citation `Sundials2005' on page 1 undefined on input line 26 Citation`Sundials2005' on page 3 undefined on input line 106 Citation `bellmann2009' on page 1 undefined on input line 41 Citation`bergen2003' on page 3 undefined on input line 118 Citation `bergen2003' on page 3 undefined on input line 125 Citation`bergen2003' on page 5 undefined on input line 329 Citation `bezanson2017julia' on page 1 undefined on input line 7 Citation`hellerer2014' on page 1 undefined on input line 41 Citation `kenwright2015' on page 3 undefined on input line 119 Citation`otter2005' on page 3 undefined on input line 164 Citation `snethen2008' on page 3 undefined on input line 117 Citation`snethen2008' on page 3 undefined on input line 119 Latexmk: Found bibliography file(s) [ref.bib] Latexmk: Summary of warnings: Latex failed to resolve 33 citation(s) Rule 'bibtex paper': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux'

Run number 2 of rule 'bibtex paper'

Running 'bibtex "paper"'

Rule 'pdflatex': File changes, etc: Changed files, or newly in use since previous run(s): 'paper.aux' 'paper.out'

Run number 3 of rule 'pdflatex'

Running 'pdflatex -recorder "paper.tex"'

Latexmk: Found input bbl file 'paper.bbl' Latexmk: Log file says output to 'paper.pdf' Latexmk: Found bibliography file(s) [ref.bib] /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/bibliography.rb:50:in read': No such file or directory @ rb_sysopen - tmp/43/paper/ref (Errno::ENOENT) from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/bibliography.rb:50:inopen' from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-5.1.4/lib/bibtex/utilities.rb:25:in open' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/bibtex_parser.rb:36:ingenerate_citations' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/compilers.rb:194:in crossref_from_latex' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/compilers.rb:19:ingenerate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/lib/whedon/processor.rb:95:in compile' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/bin/whedon:82:incompile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-0e09ec0a48e3/bin/whedon:119:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

arfon commented 4 years ago

@MartinOtter - I think this PR should fix the issue here: https://github.com/ModiaSim/Modia3D.jl/pull/13

arfon commented 4 years ago

@whedon accept from branch JuliaCon2019-paper

whedon commented 4 years ago

Attempting dry run of processing paper acceptance...

whedon commented 4 years ago

Reference check summary:

OK DOIs

- 10.1137/141000671 is OK
- 10.3384/ecp09430056 is OK
- 10.3384/ECP14096899 is OK
- 10.1007/978-3-319-47169-3_15 is OK
- 10.3384/ecp17132693 is OK
- 10.1145/3158191.3158193 is OK
- 10.3384/ECP18154175 is OK
- 10.3384/ecp19157383 is OK
- 10.1007/s11044-010-9237-4 is OK
- 10.1016/j.ijmecsci.2018.07.010 is OK
- 10.1109/56.2083 is OK
- 10.1145/1089014.1089020 is OK
- 10.5334/jors.151 is OK
- 10.1109/ICRA.2015.7139807 is OK
- 10.3384/ecp15118427 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon commented 4 years ago

:wave: @JuliaCon/jcon-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/JuliaCon/proceedings-papers/pull/30

If the paper PDF and Crossref deposit XML look good in https://github.com/JuliaCon/proceedings-papers/pull/30, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true from branch JuliaCon2019-paper

AndreaNeumayr commented 4 years ago

Great! It worked. Both look good.

matbesancon commented 4 years ago

@whedon accept deposit=true from branch JuliaCon2019-paper

whedon commented 4 years ago

Doing it live! Attempting automated processing of paper acceptance...

whedon commented 4 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JCON! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/JuliaCon/proceedings-papers/pull/31
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/jcon.00043
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

whedon commented 4 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://proceedings.juliacon.org/papers/10.21105/jcon.00043/status.svg)](https://doi.org/10.21105/jcon.00043)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/jcon.00043">
  <img src="https://proceedings.juliacon.org/papers/10.21105/jcon.00043/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://proceedings.juliacon.org/papers/10.21105/jcon.00043/status.svg
   :target: https://doi.org/10.21105/jcon.00043

This is how it will look in your documentation:

We need your help!

JuliaCon Proceedings is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://forms.gle/yANMe4c9YmuW9MWcA
Making a small donation to support our running costs here: https://numfocus.salsalabs.org/donate-to-jcon

JuliaCon / proceedings-review