Closed whedon closed 4 years ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @clagms, @jpfairbanks it looks like you're currently assigned to review this paper :tada:.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/JuliaCon/proceedings-review) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿
To fix this do the following two things:
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #52 with the following error:
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/52 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in
collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in
find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in
run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in
dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in
<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
@whedon generate pdf from branch paper
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
all good to start the review here
Authors: Does the paper.tex file include a list of authors with their affiliations?
I cannot find the repository where the *.tex files are. The pdf satisfies this criteria though.
- [ ] Page limit: Is the page limit for full papers respected by the submitted document?
Where is this limit defined? I cannot find the call for papers. Apologies for my ignorance :P
It's all on https://proceedings.juliacon.org/, reviewer and author guide. They respect the page limit, which is not too much of a big deal as long as it remains reasonable
The repository address: https://github.com/HarrisonGrodin/JuliaCon2019-Paper leads to a 404. I've updated the links to https://github.com/JuliaDiffEq/ModelingToolkit.jl but I think this was generated from the review process (so the problem is not really solved).
Right thanks, I updated the URL in another place where it needed fixing
I attach the pdf with the comments on the text: 10.21105.jcon.00052_review.pdf
ping @HarrisonGrodin can you let us know when you addressed the comments from the review? We should try to finish this soon
@harrisongrodin, Sorry for the delay in posting my notes.
I read the paper and think it should be accepted with minor revisions. I agree with most of @clagms comments.
Some broad considerations.
Expr
type directly? As a user of MT, I can't really articulate it beyond "you want to use a different type because the usage is different".Operation
to and from Expr
, this is a common question for new users of MT and should be authoritatively presented in this paper.ping @HarrisonGrodin can you let us know when you addressed the comments from the review?
We're pulling this submission.
@whedon withdraw
Paper withdrawn.
Submitting author: !--author-handle-->@HarrisonGrodin<!--end-author-handle-- (Harrison Grodin) Repository: https://github.com/JuliaDiffEq/ModelingToolkit.jl Branch with paper.md (empty if default branch): Version: Editor: !--editor-->@matbesancon<!--end-editor-- Reviewers: @clagms, @jpfairbanks Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@clagms & @jpfairbanks, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://proceedings.juliacon.org/guide/reviewers. Any questions/concerns please let @matbesancon know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @clagms
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content
Review checklist for @jpfairbanks
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content