search

JuliaContainerization / Sandbox.jl

The cultured host's toolkit for ill-mannered Linux guests.
Other
35 stars 5 forks source link

Improve sandbox `run()` wrapper to support `wait=false`. #89

Closed staticfloat closed 2 years ago

staticfloat commented 2 years ago

This solution is not totally satisfactory, as it seems a little race-y. It would be better if we somehow were able to return the Task given by the @async, but if we do that, we can't do things like send signals to the process we just launched, because we're no longer returning a Base.Process, we're returning a Task.

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (e64f9c2) into main (9236bfa) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   79.61%   79.75%   +0.14%     
==========================================
  Files           6        6              
  Lines         569      573       +4     
==========================================
+ Hits          453      457       +4     
  Misses        116      116
Impacted Files Coverage Δ
src/Sandbox.jl 73.94% <100.00%> (+0.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9236bfa...e64f9c2. Read the comment docs.