JuliaContainerization / Sandbox.jl

The cultured host's toolkit for ill-mannered Linux guests.
Other
35 stars 5 forks source link

Bindmount the sysfs into our root_dir #94

Closed DilumAluthge closed 2 years ago

DilumAluthge commented 2 years ago

https://github.com/rr-debugger/rr/pull/3187#issuecomment-1122794910

DilumAluthge commented 2 years ago

@keno Do we need all of /sys, or just some stuff under it?

codecov[bot] commented 2 years ago

Codecov Report

Merging #94 (8d12677) into main (0748b78) will increase coverage by 0.52%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   79.61%   80.14%   +0.52%     
==========================================
  Files           6        6              
  Lines         569      569              
==========================================
+ Hits          453      456       +3     
+ Misses        116      113       -3     
Impacted Files Coverage Δ
src/Sandbox.jl 75.65% <0.00%> (+2.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0748b78...8d12677. Read the comment docs.

Keno commented 2 years ago

All of sysfs should be fine.