search

JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
513 stars 85 forks source link

Type instability _bounds_and_features #169

Open mfalt opened 5 years ago

mfalt commented 5 years ago

We have some horribly type unstable code in _bounds_and_features

ronisbr commented 5 years ago

I think the biggest problem is that zpkdata is also type unstable. I understand that it is because it can be Real or Complex. However, wouldn't it be better if everything is always treated as Complex but print to the user as Real when the poles and zeros are real? I think this can help to improve the performance of some computations.