JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
508 stars 85 forks source link

warn more against high-order transfer functions #800

Closed baggepinnen closed 1 year ago

baggepinnen commented 1 year ago

This problem keeps hitting people in one form or another. This PR adds a warning when a high-order tf is created if it uses coefficients of floats that are no more precise than Float64. It also extends the already present section in the docs describing the problem with an illustrative example

codecov[bot] commented 1 year ago

Codecov Report

Merging #800 (b064857) into master (07e0354) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JuliaControlBot commented 1 year ago
This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference Reference Image New Image
:x: 0.048 Reference New
:heavy_check_mark: 0.011 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.006 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.028 Reference New
:x: 0.06 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.017 Reference New