JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
509 stars 85 forks source link

remove instance with h where it should be Ts #832

Closed albheim closed 1 year ago

albheim commented 1 year ago

Looking through some old issues I saw #447 which seemed mostly resolved, though there was this one random occurrence of h which was not even referenced in the function body, so it felt like it should be removed since it could accidentally lead to bugs with silently accepting the h and returning something other than intended.

codecov[bot] commented 1 year ago

Codecov Report

Merging #832 (b2dff5d) into master (1e1512e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           
JuliaControlBot commented 1 year ago
This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference Reference Image New Image
:x: 0.047 Reference New
:heavy_check_mark: 0.011 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.007 Reference New
:heavy_check_mark: 0.003 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.028 Reference New
:x: 0.06 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.017 Reference New