JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
509 stars 85 forks source link

apply numerical balancing before plotting #836

Closed baggepinnen closed 1 year ago

baggepinnen commented 1 year ago

Frequency-response calculations can suffer from poor accuracy for very poorly balanced models. In plotting functions, we can perform defensive balancing automatically since these are seldom performance critical. We still require to user to handle balancing elsewhere though since it changes the state representation and requires some allocations etc.

mitigates #835

codecov[bot] commented 1 year ago

Codecov Report

Merging #836 (441a7a1) into master (a5db7d9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           
JuliaControlBot commented 1 year ago
This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference Reference Image New Image
:x: 0.047 Reference New
:heavy_check_mark: 0.011 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.007 Reference New
:heavy_check_mark: 0.003 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.028 Reference New
:x: 0.06 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.017 Reference New