optimize performance of `sigma`

JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia

https://juliacontrol.github.io/ControlSystems.jl/stable/

Other

509 stars 85 forks source link

optimize performance of `sigma` #840

Closed baggepinnen closed 1 year ago

baggepinnen commented 1 year ago

For MISO and SIMO systems, it is significantly faster to call norm rather than svdvals

codecov[bot] commented 1 year ago

Codecov Report

Merging #840 (0bae63a) into master (f62c25c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9

JuliaControlBot commented 1 year ago

This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference	Reference Image	New Image
:x: 0.047
:heavy_check_mark: 0.011
:heavy_check_mark: 0.001
:heavy_check_mark: 0.001
:heavy_check_mark: 0.007
:heavy_check_mark: 0.003
:heavy_check_mark: 0.0
:warning: 0.028
:x: 0.06
:heavy_check_mark: 0.0
:warning: 0.017