JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
509 stars 85 forks source link

zpk view of `NamedStateSpace` structure #845

Closed B-LIE closed 1 year ago

B-LIE commented 1 year ago

It is not a function I use a lot, but it seems like the zpk view of linear systems in NamedStateSpace structure does not work. tf does work.

test = ss([-1 2 3; 0 -2 3; 0 0 -3],[1;2;3],[1 2 3], [0.0])

tf(test)

tf(named_ss(test))

zpk(test)

This works (however, tf does not work if all numbers are integers -- e.g., if the D-matrix of test is set to [0], tf fails.).

The following does not work:

zpk(named_ss(test))
baggepinnen commented 1 year ago

Thanks for the issue, it's closed by #847 and https://github.com/JuliaControl/ControlSystems.jl/commit/20365704630380bc739f134c0ffa379009999459