JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
509 stars 85 forks source link

remove automatic field propagation from `balance_statespace` #863

Closed baggepinnen closed 1 year ago

baggepinnen commented 1 year ago

The reason is that many abstract statespace types have fields that are affected by the balancing, and the automatic forwarding of those fields without application of the balancing led to incorrect answers. The proper way of handling this is for each type to implement their own method of balance_statespace if the additional fields are required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #863 (fd2e732) into master (e9690d9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files           5        5           
  Lines         330      330           
=======================================
  Hits          306      306           
  Misses         24       24           
JuliaControlBot commented 1 year ago
This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference Reference Image New Image
:x: 0.047 Reference New
:heavy_check_mark: 0.011 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.007 Reference New
:heavy_check_mark: 0.003 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.028 Reference New
:x: 0.06 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.017 Reference New