JuliaControl / ControlSystems.jl

A Control Systems Toolbox for Julia
https://juliacontrol.github.io/ControlSystems.jl/stable/
Other
503 stars 85 forks source link

better error message in lsim #895

Closed baggepinnen closed 9 months ago

baggepinnen commented 9 months ago

when using incorrect input-signal dimensions

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b3ffc72) 31.57% compared to head (8c8b49b) 29.66%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #895 +/- ## ========================================== - Coverage 31.57% 29.66% -1.92% ========================================== Files 43 38 -5 Lines 4624 4295 -329 ========================================== - Hits 1460 1274 -186 + Misses 3164 3021 -143 ``` | [Files](https://app.codecov.io/gh/JuliaControl/ControlSystems.jl/pull/895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaControl) | Coverage Δ | | |---|---|---| | [lib/ControlSystemsBase/src/timeresp.jl](https://app.codecov.io/gh/JuliaControl/ControlSystems.jl/pull/895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaControl#diff-bGliL0NvbnRyb2xTeXN0ZW1zQmFzZS9zcmMvdGltZXJlc3Auamw=) | `56.56% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/JuliaControl/ControlSystems.jl/pull/895/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaControl)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JuliaControlBot commented 9 months ago
This is an automated message. Plots were compared to references. 11/11 images have changed, see differences below. After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here. Difference Reference Image New Image
:x: 0.047 Reference New
:heavy_check_mark: 0.011 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.001 Reference New
:heavy_check_mark: 0.007 Reference New
:heavy_check_mark: 0.003 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.028 Reference New
:x: 0.06 Reference New
:heavy_check_mark: 0.0 Reference New
:warning: 0.017 Reference New