search

JuliaCrypto / Nettle.jl

Julia wrapper around nettle cryptographic hashing/encryption library providing MD5, SHA1, SHA2 hashing and HMAC functionality, as well as AES encryption/decryption
Other
51 stars 34 forks source link

Remove AbstractString names for Ciphers? #113

Closed nandoconde closed 2 years ago

nandoconde commented 2 years ago

Revising the code I noticed that names are saved as AbstractString. Not that it matters much performance-wise, since everything is done in the C-callee, but maybe it is unnecessary, and they could be plain old regular String.

Plus, maybe it makes sense to have them be Symbol because it is more idiomatic, but I do not feel very strong about this.

@staticfloat

staticfloat commented 2 years ago

Agreed, it should be a String, not an AbstractString.