search

JuliaCrypto / Nettle.jl

Julia wrapper around nettle cryptographic hashing/encryption library providing MD5, SHA1, SHA2 hashing and HMAC functionality, as well as AES encryption/decryption
Other
51 stars 34 forks source link

Fix symbol export #43

Closed yuyichao closed 9 years ago

yuyichao commented 9 years ago

This current_module() is unecessary and actually points to the wrong module. The one argument eval function will evaluate this in the right module already.

Maybe this can be changed to @eval as well but haven't tried. Not now, see comment below.

P.S. the missing export breaks IJulia

yuyichao commented 9 years ago

Test done: IJulia notebook works on 0.4.0-dev+4512

yuyichao commented 9 years ago

OK, I guess @eval is not possible due to sth related to JuliaLang/julia#10910

yuyichao commented 9 years ago

Is the Mac nightly travis-ci having some issue? I don't see any log.....

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 9fdf761dafaf8b54de0e3f5a4b89660a66a85bf7 on yuyichao:export-fix into \ on staticfloat:master**.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 7e61e5486e56e34e005fca348123bc21c4c11880 on yuyichao:export-fix into \ on staticfloat:master**.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 7e61e5486e56e34e005fca348123bc21c4c11880 on yuyichao:export-fix into \ on staticfloat:master**.

yuyichao commented 9 years ago

Also fix export in cipher.jl. (Previously only fixed the ones that break IJulia).

staticfloat commented 9 years ago

Excellent, thank you very much @yuyichao. Sorry again for letting this slip through the cracks unnoticed.

yuyichao commented 9 years ago

@staticfloat =) That's fine. I've been using the patched version so it didn't cause me any trouble. I guess, the explicit calling of __init__ can be removed for 0.4 now.

staticfloat commented 9 years ago

Yep, already on it. -E

On Wed, Apr 29, 2015 at 7:01 AM, Yichao Yu notifications@github.com wrote:

@staticfloat https://github.com/staticfloat =) That's fine. I've been using the patched version so it didn't cause me any trouble. I guess, the explicit calling of init can be removed for 0.4 now.

— Reply to this email directly or view it on GitHub https://github.com/staticfloat/Nettle.jl/pull/43#issuecomment-97435840.