extend `lpc` to complex inputs, other fixes

JuliaDSP / DSP.jl

Filter design, periodograms, window functions, and other digital signal processing functionality

https://docs.juliadsp.org/stable/contents/

Other

381 stars 109 forks source link

extend `lpc` to complex inputs, other fixes #517

Closed wheeheee closed 8 months ago

wheeheee commented 10 months ago

fixed wrong error estimate for levinson by scaling
levinson now has original O(n) space complexity
both arburg and levinson can now handle complex inputs
split off from #512, references #171

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3ad3c1c) 97.49% compared to head (1fd5e61) 97.56%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #517 +/- ## ========================================== + Coverage 97.49% 97.56% +0.06% ========================================== Files 18 18 Lines 3078 3121 +43 ========================================== + Hits 3001 3045 +44 + Misses 77 76 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wheeheee commented 8 months ago

Didn't realize if ... end and && behave differently. Also, if #411 is going to be merged, this would be redundant.

martinholters commented 8 months ago

Also, if https://github.com/JuliaDSP/DSP.jl/pull/411 is going to be merged, this would be redundant.

Could you expand on that?

wheeheee commented 8 months ago

_normalize!(x::AbstractArray{<:Integer}, sz::Int) = (x ./ sz)

I was referring to this, which is needed because an array of integers can't be ./=ed.