search

JuliaDSP / DSP.jl

Filter design, periodograms, window functions, and other digital signal processing functionality
https://docs.juliadsp.org/dev/
Other
374 stars 108 forks source link

add codecov token secret to CI.yml #525

Closed wheeheee closed 5 months ago

wheeheee commented 5 months ago

also added CODECOV_TOKEN Dependabot repository secret

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6c6f4fa) 97.29% compared to head (9dd734f) 97.46%. Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #525 +/- ## ========================================== + Coverage 97.29% 97.46% +0.17% ========================================== Files 18 18 Lines 3105 3080 -25 ========================================== - Hits 3021 3002 -19 + Misses 84 78 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wheeheee commented 5 months ago

Do we want CI to fail if the Codecov upload errors? I could add fail_ci_if_error: true if this is desired.

ViralBShah commented 5 months ago

I don't think we want CI to fail in case codecov upload errors. Let's see how it works out for the foreseeable future, and if we need to be more strict.

ViralBShah commented 5 months ago

It seems that the general consensus is that we should use fail_ci_if_error: true. @wheeheee would you be able to add that in a new PR? Sorry for setting you on the wrong path here.