search

JuliaDSP / DSP.jl

Filter design, periodograms, window functions, and other digital signal processing functionality
https://docs.juliadsp.org/dev/
Other
374 stars 108 forks source link

Annotate docstring arguments with types in Filters #552

Closed wheeheee closed 3 months ago

wheeheee commented 4 months ago

Addresses some concerns in #548 and implements the type restriction in #367.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.75%. Comparing base (c4f42fc) to head (c5daa66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #552 +/- ## ========================================== - Coverage 97.75% 97.75% -0.01% ========================================== Files 18 18 Lines 3202 3201 -1 ========================================== - Hits 3130 3129 -1 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ViralBShah commented 3 months ago

Merge?

wheeheee commented 3 months ago

Mostly documentation, so it should be safe, but still needs an approval to merge

ViralBShah commented 3 months ago

For obvious PRs, there is the button on "Merge without waiting for requirements to be met". I would recommend using it for various docs and maintenance PRs.