JuliaDSP / Deconvolution.jl

A Julia package for deconvolution of digital signals

https://juliadsp.github.io/Deconvolution.jl/stable/

Other

48 stars 11 forks source link

Use Documenter.jl for documentation #10

Closed abhishalya closed 4 years ago

abhishalya commented 4 years ago

This uses the Documenter.jl instead of readthedocs to generate documentation.

Closes https://github.com/JuliaDSP/Deconvolution.jl/issues/9

abhishalya commented 4 years ago

Please review @giordano

codecov-io commented 4 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          16     16           
=====================================
  Hits           16     16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad51bb0...0aeeff3. Read the comment docs.

jakubwro commented 4 years ago

I generated docs on my machine, everything works fine

giordano commented 4 years ago

@jakubwro This is my fault that I didn't finish to review #8 before (I've been out of town until a couple of days ago), but for the sake of having a speedy review of this PR for Google Code in, would you mind if I'll review and hopefully merge this one first (targeting later today) and then yours? You'll need to update the documentation, but I can take care of it if that's too much of a hassle for you.

jakubwro commented 4 years ago

@jakubwro This is my fault that I didn't finish to review #8 before (I've been out of town until a couple of days ago), but for the sake of having a speedy review of this PR for Google Code in, would you mind if I'll review and hopefully merge this one first (targeting later today) and then yours? You'll need to update the documentation, but I can take care of it if that's too much of a hassle for you.

It's not a big deal, please merge #10 and I will resolve conflicts on my branch

giordano commented 4 years ago

Thank you very much!