JuliaDSP / Deconvolution.jl

A Julia package for deconvolution of digital signals

https://juliadsp.github.io/Deconvolution.jl/stable/

Other

48 stars 11 forks source link

Added Richardson-Lucy deconvolution #8

Closed jakubwro closed 4 years ago

jakubwro commented 5 years ago

Hi, please review. If you think it's worth merging I'll update docs.

giordano commented 5 years ago

Wow, this is great, thank you very much! I'll review later.

This PR also reminds me that I should move documentation to Documenter :sweat:

codecov-io commented 5 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines          16     25    +9     
=====================================
+ Hits           16     25    +9

Impacted Files	Coverage Δ
src/Deconvolution.jl	`100% <ø> (ø)`	:arrow_up:
src/lucy.jl	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb5227...77977db. Read the comment docs.

jakubwro commented 4 years ago

Hi @giordano , I added docs and more illustrative usage example

giordano commented 4 years ago

Awesome, I'll have a look in the next few days!

jakubwro commented 4 years ago

@giordano, I readded docs, but I have a feeling that messed something with git #history. Please have a look.

giordano commented 4 years ago

The history is not a problem, we can just squash everything :wink:

I followed your struggle, I'm really sorry for this. I can feel your pain, I had similar problems a few days ago. In theses cases I think that it's easier to do a clean merge of the target branch on yours rather than rebasing.

jakubwro commented 4 years ago

The history is not a problem, we can just squash everything wink

I followed your struggle, I'm really sorry for this. I can feel your pain, I had similar problems a few days ago. In theses cases I think that it's easier to do a clean merge of the target branch on yours rather than rebasing.

Right, it's not the first time I have this problem with rebase.

giordano commented 4 years ago

Documentation is available at https://juliadsp.github.io/Deconvolution.jl/dev/. Thank you so much @jakubwro and @abhishalya! This new method looks very good!