search

JuliaDSP / FourierTransforms.jl

Fourier transforms written in Julia
MIT License
20 stars 2 forks source link

Correct a sign in Bluestein, use some exact factors. #14

Closed RalphAS closed 2 years ago

RalphAS commented 4 years ago

This change corrects a sign in the twiddle code (fixing #10) and uses exact factors for n=4, allowing for better precision.

To be clear, this addresses problems with the 1D transforms with unit stride. I think there are still troubles with non-unit stride.

codecov-io commented 4 years ago

Codecov Report

Merging #14 into master will increase coverage by 9.98%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage    68.9%   78.88%   +9.98%     
==========================================
  Files           3        3              
  Lines         328      341      +13     
==========================================
+ Hits          226      269      +43     
+ Misses        102       72      -30
Impacted Files Coverage Δ
src/ctfft.jl 90.87% <100%> (+12.74%) :arrow_up:
src/fftn.jl 37.66% <0%> (+2.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a206bc...2470b58. Read the comment docs.