search

JuliaDSP / FourierTransforms.jl

Fourier transforms written in Julia
MIT License
20 stars 2 forks source link

Fix small typo: Forgotten ωpow #9

Closed mfherbst closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    68.9%   68.9%           
======================================
  Files           3       3           
  Lines         328     328           
======================================
  Hits          226     226           
  Misses        102     102
Impacted Files Coverage Δ
src/ctfft.jl 78.12% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9600881...e2900b6. Read the comment docs.

Keno commented 5 years ago

Sorry! Note that this package may currently not be up to the highest quality and performance standards. I'm using it as the backend for https://github.com/JuliaComputing/ToyFHE.jl, but there is a bunch of cleanup to be done here that nobody has gotten around to.

mfherbst commented 5 years ago

Hi @Keno. Thanks for the note. I kind of got that from looking at the code and the fact that it's not registered. Still ... the code is actually pretty good. I compared it to FFTW in a couple of cases and it was of very similar speed for Float64, sometimes a little better, sometimes a little worse. Could be the specific cases I tested ... I was not too systematic, so take it with a grain of salt.

All in all I find the package useful as it is, since I'm currently using it to test FFTs with different floating point types (for DFTK) and I'm not too much interested in speed so far. Still ... if you need some motivation: See me as someone who would be very happy to see the code cleanup and at yet higher quality :smile:.

I'd be happy to contribute as much as I can in the process, but I'm definitely not an expert on FFTs at the required level, I'm afraid. But if you need testcases or some help profiling, just reach out.