deal with deprecated vcat warnings

JuliaDSP / MFCC.jl

Mel Frequency Cepstral Coefficients calculation for Julia

BSD 2-Clause "Simplified" License

33 stars 18 forks source link

deal with deprecated vcat warnings #3

Closed jamesdanged closed 8 years ago

jamesdanged commented 8 years ago

This is to deal with warnings such as:

WARNING: [a] concatenation is deprecated; use collect(a) instead
 in depwarn at deprecated.jl:73
 in oldstyle_vcat_warning at ./abstractarray.jl:29
 in lifter at /home/james/.julia/v0.4/MFCC/src/rasta.jl:242

and

WARNING: [a,b] concatenation is deprecated; use [a;b] instead
 in depwarn at deprecated.jl:73
 in oldstyle_vcat_warning at ./abstractarray.jl:29
 in vect at abstractarray.jl:38
 in lifter at /home/james/.julia/v0.4/MFCC/src/rasta.jl:242

davidavdav commented 8 years ago

Thanks for the PR. I happened to have been busy with MFCC just this week after a long period of standstill, and found the same deprecation warning as you, and fixed these. I hadn't pushed them yet.

Could you see if the latest checkout (with will not merge with your PR, you'll have to step back) does it for you?

jamesdanged commented 8 years ago

Sure. Those changes worked. Thanks.