JuliaDSP / MFCC.jl

Mel Frequency Cepstral Coefficients calculation for Julia
BSD 2-Clause "Simplified" License
33 stars 18 forks source link

Fixes and better loops #36

Closed wheeheee closed 1 year ago

wheeheee commented 1 year ago
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6676470376


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feacalc.jl 23 32 71.88%
src/mfccs.jl 29 57 50.88%
src/rasta.jl 37 105 35.24%
<!-- Total: 96 201 47.76% -->
Files with Coverage Reduction New Missed Lines %
src/feacalc.jl 1 45.61%
src/mfccs.jl 1 58.62%
src/rasta.jl 1 49.1%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 6610274851: 10.7%
Covered Lines: 270
Relevant Lines: 496

💛 - Coveralls
davidavdav commented 1 year ago

Thanks, I went through the diffs (in reverse order), and it looks like a pretty thorough re-write!

wheeheee commented 1 year ago

Actually I was a little confused by the code in deltas so do you mind confirming that it keeps only rows 2hlen+1 onwards? Since you've padded hlen rows in front and behind, I thought the middle would be kept after filt, but I don't really get what filt does.