Closed stevengj closed 8 years ago
Thanks, I have been wishing for this interpretation for a while. Indeed I'll have to go though all code. This code was written a while ago and probably needs some investigation for efficiency anyways, it involves mostly vectorized operations.
Your code uses
x .+= y
, so you should know that in Julia 0.5 this has changed meaning to be equivalent tobroadcast!(identity, x, x .+ y)
, so that it mutates thex
array (see JuliaLang/julia#17510 … in Julia 0.6 the whole operation will occur in-place without temporaries). So.+
should only be used if the left-hand side is a mutable array, and you don't mind mutating it.At first glance, this looks like it is okay for you, because you use it in
y .+= dither * nwin / (sumabs2(window) * sr / 2)
, wherey
seems like an array that you won't mind mutating. But if it were a problem you could always change it to+=
.