JuliaDSP / Wavelets.jl

A Julia package for fast discrete wavelet transforms and utilities
Other
184 stars 30 forks source link

Update compat #56

Closed JeffFessler closed 4 years ago

JeffFessler commented 4 years ago

Thanks for accepting the previous PR. Unfortunately when I added the [compat] section I forgot to do a package update first, so I ended up pinning things to old versions of the packages, which then causes problems when trying to use this package with others. This PR simply updates the [compat] section to the latest versions of all the relevant packages. Frankly I don't really understand why upper bounds in compat are required now, so I am not 100% sure that I have done this in the best way here. The good news at least it seems to pass the tests with the current versions of the included packages.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 90.283% when pulling a8995f5feb31b390b203c6b3af9d35f6355dbb8c on JeffFessler:master into 7f2da5b93ed6d587f60252f8df9b3d802cc5d1dc on JuliaDSP:master.

JeffFessler commented 4 years ago

So this update passes Julia 1.4 but fails tests for earlier versions of Julia. I guess one or more of the other packages must require Julia 1.4. My view is that there is little point in supporting old versions of Julia with this update of Wavelets.jl (people using older versions of Julia can use earlier releases of this package) so I have removed the tests of older versions from the CI file. Maybe there is some way to support both but I don't know how...

johnnychen94 commented 4 years ago

The test fails because you have Manifest.toml checked in, those *_jll packages are artifacts and is not compatible to Julia < 1.3

Once Manifest.toml is removed, it should be good.

JeffFessler commented 4 years ago

Thanks to @johnnychen94's help, the tests now pass so this is ready for @gummif to review.

gummif commented 4 years ago

Thanks